Dissectors don't need a journey of self discovery.

They already know who they are when they register themselves.  Saving the
handle then to avoid finding it later.
Not sure if this will increase unnecessary register_dissector functions
(instead of using create_dissector_handle in proto_reg_handoff function)
when other dissectors copy/paste, but it should make startup time
a few microseconds better.

Change-Id: I3839be791b32b84887ac51a6a65fb5733e9f1f43
Reviewed-on: https://code.wireshark.org/review/19481
Petri-Dish: Michael Mann <mmann78@netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Anders Broman <a.broman58@gmail.com>

1 files changed, 3 insertions, 4 deletions

diff --git a/epan/dissectors/packet-esis.c b/epan/dissectors/packet-esis.c
index ea8d6ad692..3230b60d11 100644
--- a/epan/dissectors/packet-esis.c
+++ b/epan/dissectors/packet-esis.c
@@ -79,6 +79,8 @@ static expert_field ei_esis_length = EI_INIT;
 static expert_field ei_esis_type = EI_INIT;
 static expert_field ei_esis_checksum = EI_INIT;
 
+static dissector_handle_t esis_handle;
+
 static const value_string esis_vals[] = {
   { ESIS_ESH_PDU, "ES HELLO"},
   { ESIS_ISH_PDU, "IS HELLO"},
@@ -400,15 +402,12 @@ proto_register_esis(void) {
   proto_register_subtree_array(ett, array_length(ett));
   expert_esis = expert_register_protocol(proto_esis);
   expert_register_field_array(expert_esis, ei, array_length(ei));
-  register_dissector("esis", dissect_esis, proto_esis);
+  esis_handle = register_dissector("esis", dissect_esis, proto_esis);
 }
 
 void
 proto_reg_handoff_esis(void)
 {
-  dissector_handle_t esis_handle;
-
-  esis_handle = find_dissector("esis");
   dissector_add_uint("osinl.incl", NLPID_ISO9542_ESIS, esis_handle);
 }