diff options
| author | Martin Mathieson <martin.r.mathieson@googlemail.com> | 2022-02-25 22:28:55 +0000 |
|---|---|---|
| committer | Martin Mathieson <martin.r.mathieson@googlemail.com> | 2022-02-25 22:52:18 +0000 |
| commit | f457caae01d6841dd64ca353b96240441b262f3f (patch) | |
| tree | 6be9978ac75cacd9c09e7742e910e3e9dbfb0aed /epan/dissectors/packet-eigrp.c | |
| parent | 462d755d8cd549319a3f3ccb6fe481074d7abb13 (diff) | |
EIGRP: Fix some item lengths
Diffstat (limited to 'epan/dissectors/packet-eigrp.c')
| -rw-r--r-- | epan/dissectors/packet-eigrp.c | 15 |
1 files changed, 10 insertions, 5 deletions
diff --git a/epan/dissectors/packet-eigrp.c b/epan/dissectors/packet-eigrp.c index e7ea7cc4d8..73f980c37f 100644 --- a/epan/dissectors/packet-eigrp.c +++ b/epan/dissectors/packet-eigrp.c @@ -2147,6 +2147,8 @@ dissect_eigrp_wide_metric_attr (proto_tree *tree, tvbuff_t *tvb, break; case EIGRP_ATTR_SCALED: + /* TODO: if this corresponds to RFC 7868, 6.9.3.2, should be scaled bandwidth + followed by scaled delay (both 32 bits) ? */ proto_tree_add_item(sub_tree, hf_eigrp_attr_scaled, sub_tvb, sub_offset, 4, ENC_BIG_ENDIAN); break; @@ -2163,16 +2165,19 @@ dissect_eigrp_wide_metric_attr (proto_tree *tree, tvbuff_t *tvb, break; case EIGRP_ATTR_JITTER: + /* TODO: RFC 7868 6.9.3.5 suggests this value should be 6 bytes */ proto_tree_add_item(sub_tree, hf_eigrp_attr_jitter, sub_tvb, sub_offset, 4, ENC_BIG_ENDIAN); break; case EIGRP_ATTR_QENERGY: + /* TODO: RFC 7868 6.9.3.6 splits this into separate high and low 16-bit values */ proto_tree_add_item(sub_tree, hf_eigrp_attr_qenergy, sub_tvb, sub_offset, 4, ENC_BIG_ENDIAN); break; case EIGRP_ATTR_ENERGY: + /* TODO: RFC 7868 6.9.3.7 splits this into separate high and low 16-bit values */ proto_tree_add_item(sub_tree, hf_eigrp_attr_energy, sub_tvb, sub_offset, 4, ENC_BIG_ENDIAN); break; @@ -3115,27 +3120,27 @@ proto_register_eigrp(void) }, { &hf_eigrp_attr_scaled, { "Legacy Metric", "eigrp.attr.scaled", - FT_UINT16, BASE_DEC, NULL, 0x0, + FT_UINT32, BASE_DEC, NULL, 0x0, "Metric calculated from legacy TLVs", HFILL } }, { &hf_eigrp_attr_tag, { "Tag", "eigrp.attr.tag", - FT_UINT16, BASE_DEC, NULL, 0x0, + FT_UINT32, BASE_DEC, NULL, 0x0, "Tag assigned by admin for dest", HFILL } }, { &hf_eigrp_attr_jitter, { "Jitter", "eigrp.attr.jitter", - FT_UINT16, BASE_DEC, NULL, 0x0, + FT_UINT32, BASE_DEC, NULL, 0x0, "Variation in path delay", HFILL } }, { &hf_eigrp_attr_qenergy, { "Q-Energy", "eigrp.attr.qenergy", - FT_UINT16, BASE_DEC, NULL, 0x0, + FT_UINT32, BASE_DEC, NULL, 0x0, "Non-Active energy usage along path", HFILL } }, { &hf_eigrp_attr_energy, { "Energy", "eigrp.attr.energy", - FT_UINT16, BASE_DEC, NULL, 0x0, + FT_UINT32, BASE_DEC, NULL, 0x0, "Active energy usage along path", HFILL } }, |