diff options
| author | Jeff Morriss <jeff.morriss.ws@gmail.com> | 2012-09-07 02:09:59 +0000 |
|---|---|---|
| committer | Jeff Morriss <jeff.morriss.ws@gmail.com> | 2012-09-07 02:09:59 +0000 |
| commit | aa5d9d78ddcb4b7066ab03afa4277fab0bf0f468 (patch) | |
| tree | 7549708474866dbbdbe811f34c57a3a7bd6ccf0b /epan/dissectors/packet-dvbci.c | |
| parent | 8ba24b5530a5916769d2fa0012de4943bac2fde3 (diff) | |
From Robert Bullen via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7683 :
The reassembled fragments tree in the Packet Details view is awesome, but it
lacks one thing: a field that exposes the reassembled data.
tcp.data already exists for exposing a single TCP segment's payload as a byte
array. It would be handy to have something similar for a single application
layer PDU when TCP segment reassembly is involved. I propose
tcp.reassembled.data, named and placed after the already existing field
tcp.reassembled.length.
My primary use case for this feature is outputting tcp.reassembled.data with
tshark for further processing with a script.
The attached patch implements this very feature. Because the reassembled
fragment tree code is general purpose, i.e. not specific to just TCP, any
dissector that relies upon it can add a similar field very cheaply. In that
vein I've also implemented ip.reassembled.data and ipv6.reassembled.data, which
expose reassembled fragment data as a single byte stream for IPv4 and IPv6,
respectively. All other protocols that use the reassembly code have been left
alone, other than inserting NULL into their initializer lists for the newly
introduced struct field reassemble.h:fragment_items.hf_reassembled_data.
svn path=/trunk/; revision=44802
Diffstat (limited to 'epan/dissectors/packet-dvbci.c')
| -rw-r--r-- | epan/dissectors/packet-dvbci.c | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/epan/dissectors/packet-dvbci.c b/epan/dissectors/packet-dvbci.c index 04e0c9fcc5..beed125720 100644 --- a/epan/dissectors/packet-dvbci.c +++ b/epan/dissectors/packet-dvbci.c @@ -1007,6 +1007,8 @@ static const fragment_items tpdu_frag_items = { &hf_dvbci_l_reass_in, &hf_dvbci_l_reass_len, + /* Reassembled data field */ + NULL, "Tpdu fragments" }; static const fragment_items spdu_frag_items = { @@ -1024,6 +1026,8 @@ static const fragment_items spdu_frag_items = { &hf_dvbci_t_reass_in, &hf_dvbci_t_reass_len, + /* Reassembled data field */ + NULL, "Spdu fragments" }; @@ -1619,7 +1623,7 @@ store_lsc_msg_dissector(circuit_t *circuit, guint8 ip_proto, guint16 port) circuit_set_dissector(circuit, msg_handle); } - + /* dissect a connection_descriptor for the lsc resource returns its length or -1 for error */ static gint |