aboutsummaryrefslogtreecommitdiffstats
path: root/epan/dissectors/packet-dsi.c
diff options
context:
space:
mode:
authorGuy Harris <gharris@sonic.net>2022-09-04 17:08:17 -0700
committerGuy Harris <gharris@sonic.net>2022-09-04 18:13:06 -0700
commiteb83e055b855d23802a25d5de6e3c8682f38fb9d (patch)
treed29f20f743cc5bc7137fd15231265c7011aa879e /epan/dissectors/packet-dsi.c
parentab4a4304eec6bac7df5e92dd589a60be8089ab7a (diff)
AppleTalk, DSI: get rid of the "command" field.
It's not needed. Instead, have get_transaction() return the request_val; the caller can fetch the command from its "value" member. While wee're at it, update some of the web reference information for DSI.
Diffstat (limited to 'epan/dissectors/packet-dsi.c')
-rw-r--r--epan/dissectors/packet-dsi.c13
1 files changed, 9 insertions, 4 deletions
diff --git a/epan/dissectors/packet-dsi.c b/epan/dissectors/packet-dsi.c
index b355b28189..962eee4fe9 100644
--- a/epan/dissectors/packet-dsi.c
+++ b/epan/dissectors/packet-dsi.c
@@ -25,15 +25,21 @@
http://developer.apple.com/DOCUMENTATION/macos8/pdf/ASAppleTalkFiling2.1_2.2.pdf
+ which is no longer available and does not appear to be in the Wayback Machine.
+
The netatalk source code by Wesley Craig & Adrian Sun
The Data Stream Interface description from
- http://developer.apple.com/documentation/Networking/Conceptual/AFPClient/AFPClient-6.html
-(no longer available, apparently)
+http://developer.apple.com/documentation/Networking/Conceptual/AFPClient/AFPClient-6.html
+
+ which is no longer available, but is archived at
+
+https://web.archive.org/web/20040924082047/http://developer.apple.com/documentation/Networking/Conceptual/AFPClient/AFPClient-6.html
Also, AFP 3.3 documents parts of DSI at:
- http://developer.apple.com/mac/library/documentation/Networking/Conceptual/AFP/Introduction/Introduction.html
+
+http://developer.apple.com/mac/library/documentation/Networking/Conceptual/AFP/Introduction/Introduction.html
* What a Data Stream Interface packet looks like:
* 0 32
@@ -289,7 +295,6 @@ dissect_dsi_packet(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree, void* da
tvbuff_t *new_tvb;
atp_asp_dsi_info.reply = (dsi_flags == DSIFL_REPLY);
- atp_asp_dsi_info.command = dsi_command;
atp_asp_dsi_info.tid = dsi_requestid;
atp_asp_dsi_info.code = dsi_code;
proto_item_set_len(dsi_ti, DSI_BLOCKSIZ);