diff options
| author | Alexis La Goutte <alexis.lagoutte@gmail.com> | 2013-04-20 09:49:12 +0000 |
|---|---|---|
| committer | Alexis La Goutte <alexis.lagoutte@gmail.com> | 2013-04-20 09:49:12 +0000 |
| commit | cf0a2c952e30fe6bf250fc04a76c423881e4b448 (patch) | |
| tree | e495520cbd546003c1ffb2d738e2ebcd19ec6a58 /epan/dissectors/packet-dns.c | |
| parent | 579deaa7b96ae9c946693c5917b2114ea26d85df (diff) | |
Remove expert info for bit AD in DNS query
See Section 5.7 (Setting the AD Bit on Queries) of RFC 6840 (Clarifications and Implementation Notes for DNS Security (DNSSEC))
The semantics of the Authentic Data (AD) bit in the query were
previously undefined. Section 4.6 of [RFC4035] instructed resolvers
to always clear the AD bit when composing queries.
This document defines setting the AD bit in a query as a signal
indicating that the requester understands and is interested in the
value of the AD bit in the response. This allows a requester to
indicate that it understands the AD bit without also requesting
DNSSEC data via the DO bit.
svn path=/trunk/; revision=48942
Diffstat (limited to 'epan/dissectors/packet-dns.c')
| -rw-r--r-- | epan/dissectors/packet-dns.c | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/epan/dissectors/packet-dns.c b/epan/dissectors/packet-dns.c index 354a75c845..cc64c20a5c 100644 --- a/epan/dissectors/packet-dns.c +++ b/epan/dissectors/packet-dns.c @@ -3629,10 +3629,8 @@ dissect_dns_common(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree, proto_tree_add_item(field_tree, hf_dns_flags_authenticated, tvb, offset + DNS_FLAGS, 2, ENC_BIG_ENDIAN); } else if (flags & F_AUTHENTIC) { - proto_item *pi = proto_tree_add_item(field_tree, hf_dns_flags_ad, + proto_tree_add_item(field_tree, hf_dns_flags_ad, tvb, offset + DNS_FLAGS, 2, ENC_BIG_ENDIAN); - expert_add_info_format(pinfo, pi, PI_SECURITY, PI_WARN, - "AD bit set in DNS Query"); } proto_tree_add_item(field_tree, hf_dns_flags_checkdisable, tvb, offset + DNS_FLAGS, 2, ENC_BIG_ENDIAN); |