diff options
| author | Dario Lombardo <lomato@gmail.com> | 2016-04-01 12:39:38 +0200 |
|---|---|---|
| committer | Michael Mann <mmann78@netscape.net> | 2016-04-04 12:12:22 +0000 |
| commit | 2fd8e4bdaa33f38af9b539ff0f704acfa8b1fd69 (patch) | |
| tree | 25208c304b1410667b226ad5eae85341f11d7323 /epan/dissectors/packet-dns.c | |
| parent | 6f98a0fac33db70b3ceb71d939b0a9d0d47747cc (diff) | |
DNS: change ttl from uint32 to int32.
As stated in the RFC1035 the TTL is a signed int.
https://tools.ietf.org/html/rfc1035#section-3.2.1
Change-Id: I07e57309f83f1877b1b4cb6a085bc3dabf053379
Reviewed-on: https://code.wireshark.org/review/14759
Petri-Dish: Dario Lombardo <lomato@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
Reviewed-by: Michael Mann <mmann78@netscape.net>
Diffstat (limited to 'epan/dissectors/packet-dns.c')
| -rw-r--r-- | epan/dissectors/packet-dns.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/epan/dissectors/packet-dns.c b/epan/dissectors/packet-dns.c index 47268e9e5e..4e99c5e4d4 100644 --- a/epan/dissectors/packet-dns.c +++ b/epan/dissectors/packet-dns.c @@ -1511,7 +1511,7 @@ add_rr_to_tree(proto_tree *rr_tree, tvbuff_t *tvb, int offset, proto_tree_add_item(rr_tree, hf_dns_rr_class, tvb, offset, 2, ENC_BIG_ENDIAN); } offset += 2; - ttl_item = proto_tree_add_item(rr_tree, hf_dns_rr_ttl, tvb, offset, 4, ENC_BIG_ENDIAN|ENC_TIME_TIMESPEC); + ttl_item = proto_tree_add_item(rr_tree, hf_dns_rr_ttl, tvb, offset, 4, ENC_BIG_ENDIAN); if (tvb_get_ntohl(tvb, offset) & 0x80000000) { expert_add_info(pinfo, ttl_item, &ei_ttl_negative); } @@ -4386,7 +4386,7 @@ proto_register_dns(void) { &hf_dns_rr_ttl, { "Time to live", "dns.resp.ttl", - FT_UINT32, BASE_DEC, NULL, 0x0, + FT_INT32, BASE_DEC, NULL, 0x0, "Response TTL", HFILL }}, { &hf_dns_rr_len, |