diff options
| author | Alexis La Goutte <alexis.lagoutte@gmail.com> | 2015-02-07 21:54:39 +0100 |
|---|---|---|
| committer | Michael Mann <mmann78@netscape.net> | 2015-02-08 22:44:05 +0000 |
| commit | 3b81c360ded5b81d9affe324435f358590220341 (patch) | |
| tree | a4aa075b0b1f8633310adeaaa893ab123b850b87 /epan/dissectors/packet-dns.c | |
| parent | 0a2832c4be6741c0389c1c561dd2b69a04691dc9 (diff) | |
DNS: LOC Precision missing units
The DNS packet's 3rd additional RR is a LOC RR.
In the LOC RR, Wireshark marks the Size field with meters unit.
However, the Horizontal and Vertical Precision fields have no units
Issue reported by Boaz
Bug:10940
Change-Id: If177757d2bba6ea012a320aceaea2f8d8e50155c
Reviewed-on: https://code.wireshark.org/review/7014
Reviewed-by: Michael Mann <mmann78@netscape.net>
Diffstat (limited to 'epan/dissectors/packet-dns.c')
| -rw-r--r-- | epan/dissectors/packet-dns.c | 12 |
1 files changed, 6 insertions, 6 deletions
diff --git a/epan/dissectors/packet-dns.c b/epan/dissectors/packet-dns.c index 0ffb70ef60..d9fd89fe22 100644 --- a/epan/dissectors/packet-dns.c +++ b/epan/dissectors/packet-dns.c @@ -2427,27 +2427,27 @@ dissect_dns_answer(tvbuff_t *tvb, int offsetx, int dns_data_offset, cur_offset++; ti = proto_tree_add_item(rr_tree, hf_dns_loc_size, tvb, cur_offset, 1, ENC_BIG_ENDIAN); - proto_item_append_text(ti, "(%g m)", rfc1867_size(tvb, cur_offset)); + proto_item_append_text(ti, " (%g m)", rfc1867_size(tvb, cur_offset)); cur_offset++; ti = proto_tree_add_item(rr_tree, hf_dns_loc_horizontal_precision, tvb, cur_offset, 1, ENC_BIG_ENDIAN); - proto_item_append_text(ti, "(%g)", rfc1867_size(tvb, cur_offset)); + proto_item_append_text(ti, " (%g m)", rfc1867_size(tvb, cur_offset)); cur_offset++; ti = proto_tree_add_item(rr_tree, hf_dns_loc_vertical_precision, tvb, cur_offset, 1, ENC_BIG_ENDIAN); - proto_item_append_text(ti, "(%g)", rfc1867_size(tvb, cur_offset)); + proto_item_append_text(ti, " (%g m)", rfc1867_size(tvb, cur_offset)); cur_offset++; ti = proto_tree_add_item(rr_tree, hf_dns_loc_latitude, tvb, cur_offset, 4, ENC_BIG_ENDIAN); - proto_item_append_text(ti, "(%s)", rfc1867_angle(tvb, cur_offset, "NS")); + proto_item_append_text(ti, " (%s)", rfc1867_angle(tvb, cur_offset, "NS")); cur_offset += 4; ti = proto_tree_add_item(rr_tree, hf_dns_loc_longitude, tvb, cur_offset, 4, ENC_BIG_ENDIAN); - proto_item_append_text(ti, "(%s)", rfc1867_angle(tvb, cur_offset, "EW")); + proto_item_append_text(ti, " (%s)", rfc1867_angle(tvb, cur_offset, "EW")); cur_offset += 4; ti = proto_tree_add_item(rr_tree, hf_dns_loc_altitude, tvb, cur_offset, 4, ENC_BIG_ENDIAN); - proto_item_append_text(ti, "(%g m)", ((gint32)tvb_get_ntohl(tvb, cur_offset) - 10000000)/100.0); + proto_item_append_text(ti, " (%g m)", ((gint32)tvb_get_ntohl(tvb, cur_offset) - 10000000)/100.0); } else { proto_tree_add_item(rr_tree, hf_dns_loc_unknown_data, tvb, cur_offset, data_len, ENC_NA); } |