diff options
author | João Valverde <joao.valverde@tecnico.ulisboa.pt> | 2015-11-21 23:48:27 +0000 |
---|---|---|
committer | Michael Mann <mmann78@netscape.net> | 2015-12-12 16:21:19 +0000 |
commit | 2aab706c5a5d61c61bbff6e9e36a57afc4ef3be8 (patch) | |
tree | 311fa08b5404d23cc4cfa644c87f84ab7422b61f /epan/dissectors/packet-diameter.c | |
parent | 95142cf09d4789c9c68108b56f5fbe467108494f (diff) |
Remove -Wwrite-strings compiler flag
The "-Wwrite-strings" flag produces nuisance warnings. These warnings are
not useful, they're impossible to fix in a sane way and therefore are being
handled with casts of static strings to (char *).
This just moves the warning to [-Wcast-qual] and a compiler pragma is
in turn required (and used) to squelch that warning.
Remove the Wwrite-strings warning. Let that responsibility fall on the
programmer (as is done by casting).
Change-Id: I5a44dfd9decd6d80797a521a3373593074962fb5
Reviewed-on: https://code.wireshark.org/review/12162
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
Reviewed-by: Michael Mann <mmann78@netscape.net>
Diffstat (limited to 'epan/dissectors/packet-diameter.c')
-rw-r--r-- | epan/dissectors/packet-diameter.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/epan/dissectors/packet-diameter.c b/epan/dissectors/packet-diameter.c index 3cdb016e51..5ed573b44c 100644 --- a/epan/dissectors/packet-diameter.c +++ b/epan/dissectors/packet-diameter.c @@ -387,7 +387,7 @@ diameterstat_init(struct register_srt* srt _U_, GArray* srt_array, srt_gui_init_ idx = (int *)g_malloc(sizeof(int)); *idx = 0; diameterstat_cmd_str_hash = g_hash_table_new(g_str_hash,g_str_equal); - g_hash_table_insert(diameterstat_cmd_str_hash, (gchar *)"Unknown", idx); + g_hash_table_insert(diameterstat_cmd_str_hash, "Unknown", idx); /** @todo the filter to use in stead of NULL is "diameter.cmd.code" * to enable the filter popup in the service response time dalouge @@ -1882,7 +1882,7 @@ dictionary_load(void) all_cmds = g_array_new(TRUE,TRUE,sizeof(value_string)); wmem_tree_insert32(dictionary.vnds,0,&no_vnd); - g_hash_table_insert(vendors,(gchar *)"None",&no_vnd); + g_hash_table_insert(vendors,"None",&no_vnd); /* initialize the types hash with the known basic types */ for (type = basic_types; type->name; type++) { |