aboutsummaryrefslogtreecommitdiffstats
path: root/epan/dissectors/packet-dcerpc-spoolss.c
diff options
context:
space:
mode:
authorDario Lombardo <lomato@gmail.com>2017-12-29 19:26:11 +0100
committerAnders Broman <a.broman58@gmail.com>2018-01-03 12:38:37 +0000
commitc6a065ee7ae37449a5491a12f2956119a2095a28 (patch)
tree73a2e481317d692dbbd96ddd40ab99cde8260a98 /epan/dissectors/packet-dcerpc-spoolss.c
parent6bd539d51f45a756f40ee2a5c3712845c6f5a1a4 (diff)
dcerpc-spoolss: use value_name variable to store string (CID: 1158734).
Change-Id: I30780134b3d8a8e48b8b4997ea27ce82171b4508 Reviewed-on: https://code.wireshark.org/review/25069 Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
Diffstat (limited to 'epan/dissectors/packet-dcerpc-spoolss.c')
-rw-r--r--epan/dissectors/packet-dcerpc-spoolss.c8
1 files changed, 3 insertions, 5 deletions
diff --git a/epan/dissectors/packet-dcerpc-spoolss.c b/epan/dissectors/packet-dcerpc-spoolss.c
index 5191c9fab1..5145f2ebb6 100644
--- a/epan/dissectors/packet-dcerpc-spoolss.c
+++ b/epan/dissectors/packet-dcerpc-spoolss.c
@@ -781,13 +781,11 @@ SpoolssGetPrinterData_q(tvbuff_t *tvb, int offset,
value_name = NULL;
offset = dissect_ndr_cvstring(
tvb, offset, pinfo, tree, di, drep, sizeof(guint16),
- hf_printerdata_value, TRUE, NULL);
+ hf_printerdata_value, TRUE, &value_name);
/* GetPrinterData() stores the printerdata in se_data */
if(!pinfo->fd->flags.visited){
- if(!dcv->se_data){
- if(value_name){
- dcv->se_data = wmem_strdup(wmem_file_scope(), value_name);
- }
+ if(!dcv->se_data && value_name){
+ dcv->se_data = wmem_strdup(wmem_file_scope(), value_name);
}
}