diff options
| author | Michael Mann <mmann78@netscape.net> | 2016-12-16 20:06:11 -0500 |
|---|---|---|
| committer | Anders Broman <a.broman58@gmail.com> | 2016-12-31 07:31:42 +0000 |
| commit | f4b0abc7296bbb431e64e31f85b24c29196c2ae4 (patch) | |
| tree | 68394f5fdfa1987900f0b079d0ecfd34003e8a5a /epan/dissectors/packet-db-lsp.c | |
| parent | 13964595ad09e5d1115f6c5cb604cded27f9f55d (diff) | |
Dissectors don't need a journey of self discovery.
They already know who they are when they register themselves. Saving the
handle then to avoid finding it later.
Not sure if this will increase unnecessary register_dissector functions
(instead of using create_dissector_handle in proto_reg_handoff function)
when other dissectors copy/paste, but it should make startup time
a few microseconds better.
Change-Id: I3839be791b32b84887ac51a6a65fb5733e9f1f43
Reviewed-on: https://code.wireshark.org/review/19481
Petri-Dish: Michael Mann <mmann78@netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
Diffstat (limited to 'epan/dissectors/packet-db-lsp.c')
| -rw-r--r-- | epan/dissectors/packet-db-lsp.c | 13 |
1 files changed, 5 insertions, 8 deletions
diff --git a/epan/dissectors/packet-db-lsp.c b/epan/dissectors/packet-db-lsp.c index 14ec08f8fa..88f9c3012c 100644 --- a/epan/dissectors/packet-db-lsp.c +++ b/epan/dissectors/packet-db-lsp.c @@ -59,6 +59,9 @@ static gint ett_db_lsp = -1; static heur_dissector_list_t heur_subdissector_list; +static dissector_handle_t db_lsp_tcp_handle; +static dissector_handle_t db_lsp_udp_handle; + /* Use heuristic */ static gboolean try_heuristic = TRUE; /* desegmentation of tcp payload */ @@ -237,8 +240,8 @@ proto_register_db_lsp (void) proto_db_lsp = proto_register_protocol (PNAME, PSNAME, PFNAME); proto_db_lsp_disc = proto_register_protocol (PNAME_DISC, PSNAME_DISC, PFNAME_DISC); - register_dissector ("db-lsp.tcp", dissect_db_lsp_tcp, proto_db_lsp); - register_dissector ("db-lsp.udp", dissect_db_lsp_disc, proto_db_lsp_disc); + db_lsp_tcp_handle = register_dissector ("db-lsp.tcp", dissect_db_lsp_tcp, proto_db_lsp); + db_lsp_udp_handle = register_dissector ("db-lsp.udp", dissect_db_lsp_disc, proto_db_lsp_disc); heur_subdissector_list = register_heur_dissector_list("db-lsp", proto_db_lsp); @@ -265,12 +268,6 @@ proto_register_db_lsp (void) void proto_reg_handoff_db_lsp (void) { - dissector_handle_t db_lsp_tcp_handle; - dissector_handle_t db_lsp_udp_handle; - - db_lsp_tcp_handle = find_dissector ("db-lsp.tcp"); - db_lsp_udp_handle = find_dissector ("db-lsp.udp"); - dissector_add_uint_with_preference("tcp.port", DB_LSP_PORT, db_lsp_tcp_handle); dissector_add_uint_with_preference("udp.port", DB_LSP_PORT, db_lsp_udp_handle); } |