diff options
| author | Michael Mann <mmann78@netscape.net> | 2016-12-16 20:06:11 -0500 |
|---|---|---|
| committer | Anders Broman <a.broman58@gmail.com> | 2016-12-31 07:31:42 +0000 |
| commit | f4b0abc7296bbb431e64e31f85b24c29196c2ae4 (patch) | |
| tree | 68394f5fdfa1987900f0b079d0ecfd34003e8a5a /epan/dissectors/packet-cops.c | |
| parent | 13964595ad09e5d1115f6c5cb604cded27f9f55d (diff) | |
Dissectors don't need a journey of self discovery.
They already know who they are when they register themselves. Saving the
handle then to avoid finding it later.
Not sure if this will increase unnecessary register_dissector functions
(instead of using create_dissector_handle in proto_reg_handoff function)
when other dissectors copy/paste, but it should make startup time
a few microseconds better.
Change-Id: I3839be791b32b84887ac51a6a65fb5733e9f1f43
Reviewed-on: https://code.wireshark.org/review/19481
Petri-Dish: Michael Mann <mmann78@netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
Diffstat (limited to 'epan/dissectors/packet-cops.c')
| -rw-r--r-- | epan/dissectors/packet-cops.c | 7 |
1 files changed, 3 insertions, 4 deletions
diff --git a/epan/dissectors/packet-cops.c b/epan/dissectors/packet-cops.c index a23d61e91f..fd91cf0419 100644 --- a/epan/dissectors/packet-cops.c +++ b/epan/dissectors/packet-cops.c @@ -798,6 +798,8 @@ static gint ett_cops_subtree = -1; static gint ett_docsis_request_transmission_policy = -1; +static dissector_handle_t cops_handle; + /* For request/response matching */ typedef struct _cops_conv_info_t { wmem_map_t *pdus_tree; @@ -2842,7 +2844,7 @@ void proto_register_cops(void) expert_register_field_array(expert_cops, ei, array_length(ei)); /* Make dissector findable by name */ - register_dissector("cops", dissect_cops, proto_cops); + cops_handle = register_dissector("cops", dissect_cops, proto_cops); /* Register our configuration options for cops */ cops_module = prefs_register_protocol(proto_cops, NULL); @@ -2867,9 +2869,6 @@ void proto_register_cops(void) void proto_reg_handoff_cops(void) { - dissector_handle_t cops_handle; - - cops_handle = find_dissector("cops"); /* These could use a separate "preference name" (to avoid collision), but they are IANA registered and users could still use Decode As */ dissector_add_uint("tcp.port", TCP_PORT_PKTCABLE_COPS, cops_handle); |