diff options
| author | Alexis La Goutte <alexis.lagoutte@gmail.com> | 2015-01-12 20:04:32 +0100 |
|---|---|---|
| committer | Michael Mann <mmann78@netscape.net> | 2015-01-17 22:26:09 +0000 |
| commit | be113e8806796faf048d6c95c1141525ab5da29e (patch) | |
| tree | 95153d92e1b9f883a5702c6e611b6a2e3ab0a9c0 /epan/dissectors/packet-bootp.c | |
| parent | 506409d28cf727333b354a328a50e5a5f12552e9 (diff) | |
DHCP/BOOTP: Option 125 Suboption: (1) option-len always expects 1 but specification allows for more
We believe this is a bug in Wireshark with Option 125 Suboption: (1) option-len where Wireshark always expects 1 but specification is more flexible.
Re: http://www.cablelabs.com/wp-content/uploads/specdocs/CL-SP-CANN-DHCP-Reg-I10-1308081.pdf page 15 part 4.2.2 'The DHCPv4 Option Request Option'
Issue reported by Steve Krebs
Bug:10784
Change-Id: I8eced7a70877d13d925b81c0f47885609baa7633
Reviewed-on: https://code.wireshark.org/review/6510
Reviewed-by: Michael Mann <mmann78@netscape.net>
Diffstat (limited to 'epan/dissectors/packet-bootp.c')
| -rw-r--r-- | epan/dissectors/packet-bootp.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/epan/dissectors/packet-bootp.c b/epan/dissectors/packet-bootp.c index b0eed1c1b2..be97d7a3d3 100644 --- a/epan/dissectors/packet-bootp.c +++ b/epan/dissectors/packet-bootp.c @@ -3679,7 +3679,7 @@ dissect_vendor_cl_suboption(packet_info *pinfo, proto_item *v_ti, proto_tree *v_ static struct opt_info o125_cl_opt[]= { /* 0 */ {"nop", special, NULL}, /* dummy */ - /* 1 */ {"Option Request = ", val_u_byte, &hf_bootp_option125_cl_option_request}, + /* 1 */ {"Option Request = ", bytes, &hf_bootp_option125_cl_option_request}, /* 2 */ {"TFTP Server Addresses : ", ipv4_list, &hf_bootp_option125_cl_tftp_server_addresses}, /* 3 */ {"eRouter Container Option : ", bytes, &hf_bootp_option125_cl_erouter_container_option}, /* 4 */ {"MIB Environment Indicator Option = ", val_u_byte, &hf_bootp_option125_cl_mib_environment_indicator_option}, @@ -6864,7 +6864,7 @@ proto_register_bootp(void) { &hf_bootp_option125_cl_option_request, { "Option Request", "bootp.option.vi.cl.option_request", - FT_UINT8, BASE_DEC, NULL, 0x0, + FT_BYTES, SEP_SPACE, NULL, 0x0, "Option 125:CL 1 Option Request", HFILL }}, { &hf_bootp_option125_cl_tftp_server_addresses, |