diff options
| author | Guy Harris <guy@alum.mit.edu> | 2005-09-12 07:44:11 +0000 |
|---|---|---|
| committer | Guy Harris <guy@alum.mit.edu> | 2005-09-12 07:44:11 +0000 |
| commit | 346e5e211cffa89dd51304236e73070db8924ef4 (patch) | |
| tree | d6ff42bc087a60c902eb51d863cab0874c0ffb7e /epan/dissectors/packet-arp.c | |
| parent | fec9c0ec2b1e8c6426a7ef9bacb0955311387147 (diff) | |
The previous checkin for packet-isup.c was accidentally checked in along
with some unrelated changes; it got rid of some calls to get IPv4/IPv6
addresses and add them to the protocol tree, replacing them with
proto_tree_add_item() calls, and fixed up the length of one protocol
tree item.
Note that we have (at least) three count 'em three different routines
for dissecting/displaying NSAPs (there might be more - I might have
missed some), and suggest that we might want to reduce that to one.
Update the URL for ICP values for IPv{4,6} addresses inside NSAPs.
Fix the offset in the call to add the IPv6 address part of an NSAP
containing such an address, and the length in the call adding the DSP
for an NSAP containing an IPv4 address.
Fix up indentation a bit.
svn path=/trunk/; revision=15766
Diffstat (limited to 'epan/dissectors/packet-arp.c')
| -rw-r--r-- | epan/dissectors/packet-arp.c | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/epan/dissectors/packet-arp.c b/epan/dissectors/packet-arp.c index a223bf8723..79eb542469 100644 --- a/epan/dissectors/packet-arp.c +++ b/epan/dissectors/packet-arp.c @@ -296,6 +296,11 @@ dissect_atm_number(tvbuff_t *tvb, int offset, int tl, int hf_e164, } } +/* + * XXX - shouldn't there be a centralized routine for dissecting NSAPs? + * See also "dissect_nsap()" in epan/dissectors/packet-isup.c and + * "print_nsap_net_buf()" and "print_nsap_net()" in epan/osi=utils.c. + */ void dissect_atm_nsap(tvbuff_t *tvb, int offset, int len, proto_tree *tree) { |