diff options
| author | stig <stig@f5534014-38df-0310-8fa8-9805f1628bb7> | 2008-02-02 17:25:40 +0000 |
|---|---|---|
| committer | stig <stig@f5534014-38df-0310-8fa8-9805f1628bb7> | 2008-02-02 17:25:40 +0000 |
| commit | fb0926df1f60e92e0cbe76b005accf1294978df6 (patch) | |
| tree | be5bef5296434902f49f006f350c91544fdda44d /epan/dissectors/packet-afs.c | |
| parent | e5202656745872126717a426d677b3b6561e28ca (diff) | |
Rewrote some prohibited APIs in epan/dissectors/ (sprintf, strcpy, strcat).
If we get some truncated strings we probably overwrote some buffers...
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24249 f5534014-38df-0310-8fa8-9805f1628bb7
Diffstat (limited to 'epan/dissectors/packet-afs.c')
| -rw-r--r-- | epan/dissectors/packet-afs.c | 14 |
1 files changed, 7 insertions, 7 deletions
diff --git a/epan/dissectors/packet-afs.c b/epan/dissectors/packet-afs.c index 636d5615e5..1c115be39e 100644 --- a/epan/dissectors/packet-afs.c +++ b/epan/dissectors/packet-afs.c @@ -649,13 +649,13 @@ static gint ett_afs_vldb_flags = -1; int acllen; \ char tmp[10]; \ tmp[0] = 0; \ - if ( acl & PRSFS_READ ) strcat(tmp, "r"); \ - if ( acl & PRSFS_LOOKUP ) strcat(tmp, "l"); \ - if ( acl & PRSFS_INSERT ) strcat(tmp, "i"); \ - if ( acl & PRSFS_DELETE ) strcat(tmp, "d"); \ - if ( acl & PRSFS_WRITE ) strcat(tmp, "w"); \ - if ( acl & PRSFS_LOCK ) strcat(tmp, "k"); \ - if ( acl & PRSFS_ADMINISTER ) strcat(tmp, "a"); \ + if ( acl & PRSFS_READ ) strncat(tmp, "r", 2); \ + if ( acl & PRSFS_LOOKUP ) strncat(tmp, "l", 2); \ + if ( acl & PRSFS_INSERT ) strncat(tmp, "i", 2); \ + if ( acl & PRSFS_DELETE ) strncat(tmp, "d", 2); \ + if ( acl & PRSFS_WRITE ) strncat(tmp, "w", 2); \ + if ( acl & PRSFS_LOCK ) strncat(tmp, "k", 2); \ + if ( acl & PRSFS_ADMINISTER ) strncat(tmp, "a", 2); \ ti = proto_tree_add_text(tree, tvb, offset, bytes, \ "ACL: %s %s%s", \ who, tmp, positive ? "" : " (negative)"); \ |