aboutsummaryrefslogtreecommitdiffstats
path: root/epan/dissectors/packet-acse.c
diff options
context:
space:
mode:
authorGerald Combs <gerald@wireshark.org>2005-10-18 13:36:32 +0000
committerGerald Combs <gerald@wireshark.org>2005-10-18 13:36:32 +0000
commitf4eaf406488595c352715d034e1aa6d38af6ac50 (patch)
tree65836e28e0c74628399776892f056b8b8aa3cfce /epan/dissectors/packet-acse.c
parent39fb4b837835de20208df8abdac932202d667202 (diff)
Don't pass a null value to strcmp(). Fixes bug 540.
svn path=/trunk/; revision=16262
Diffstat (limited to 'epan/dissectors/packet-acse.c')
-rw-r--r--epan/dissectors/packet-acse.c11
1 files changed, 6 insertions, 5 deletions
diff --git a/epan/dissectors/packet-acse.c b/epan/dissectors/packet-acse.c
index c29e4646fc..a7270f18b8 100644
--- a/epan/dissectors/packet-acse.c
+++ b/epan/dissectors/packet-acse.c
@@ -1893,11 +1893,12 @@ dissect_acse(tvbuff_t *tvb, packet_info *pinfo, proto_tree *parent_tree)
break;
case SES_DATA_TRANSFER:
oid=find_oid_by_pres_ctx_id(pinfo, indir_ref);
- if(strcmp(oid, ACSE_APDU_OID) == 0){
- proto_tree_add_text(parent_tree, tvb, offset, -1,
- "Invalid OID: %s", ACSE_APDU_OID);
- THROW(ReportedBoundsError);
- } else if(oid){
+ if(oid){
+ if(strcmp(oid, ACSE_APDU_OID) == 0){
+ proto_tree_add_text(parent_tree, tvb, offset, -1,
+ "Invalid OID: %s", ACSE_APDU_OID);
+ THROW(ReportedBoundsError);
+ }
call_ber_oid_callback(oid, tvb, offset, pinfo, parent_tree);
} else {
proto_tree_add_text(parent_tree, tvb, offset, -1,