diff options
| author | Evan Huus <eapache@gmail.com> | 2012-10-27 02:48:45 +0000 |
|---|---|---|
| committer | Evan Huus <eapache@gmail.com> | 2012-10-27 02:48:45 +0000 |
| commit | 43fadb88cb8dc24e01c2e78139fc19bce3e997a9 (patch) | |
| tree | aa0adbe7b39b8e5a5e1aff992cbe415f5d09c605 /epan/column-utils.c | |
| parent | b464dcd8888d1cd8ad4e16022d358d555a27f4fd (diff) | |
Add comment explaining the addr->hf field to column-utils for future
reference. Those lines were already starting to look like magic and
it's only been 24 hours.
svn path=/trunk/; revision=45806
Diffstat (limited to 'epan/column-utils.c')
| -rw-r--r-- | epan/column-utils.c | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/epan/column-utils.c b/epan/column-utils.c index 208af563b6..8953a01f51 100644 --- a/epan/column-utils.c +++ b/epan/column-utils.c @@ -1493,6 +1493,12 @@ col_set_addr(packet_info *pinfo, const int col, const address *addr, const gbool break; } + /* Some addresses (e.g. ieee80211) use a standard format like AT_ETHER but + * don't use the same hf_ value (and thus don't use the same filter string). + * Such address can use the SET_ADDRESS_HF macro to pass in the specific hf_ + * value they use. If they did so, we overwrite the default filter string + * with their specific one here. See bug #7728 for further discussion. + * https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7728 */ if (addr->hf != -1) { pinfo->cinfo->col_expr.col_expr[col] = proto_registrar_get_nth(addr->hf)->abbrev; } |