diff options
| author | Jakub Zawadzki <darkjames-ws@darkjames.pl> | 2018-02-01 23:48:29 +0100 |
|---|---|---|
| committer | Jakub Zawadzki <darkjames-ws@darkjames.pl> | 2018-02-01 23:17:19 +0000 |
| commit | 4a417149d42517037ee7a6c8aebc7b792f00260f (patch) | |
| tree | f12217dc82837a33efa2302321ab37c46d435bf1 /epan/color_filters.c | |
| parent | 5c511d23e36b098c93ed1b3070a445c8e16185d2 (diff) | |
Fix memleak in color_filters_read_globals()
Valgrind log:
==6102== Thread 1:
==6102== 32 bytes in 1 blocks are definitely lost in loss record 24,851 of 49,782
==6102== at 0x4C29C4F: malloc (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so)
==6102== by 0xB17B7F7: __vasprintf_chk (vasprintf_chk.c:80)
==6102== by 0xA98C2AB: vasprintf (stdio2.h:210)
==6102== by 0xA98C2AB: g_vasprintf (gprintf.c:316)
==6102== by 0xA966DCC: g_strdup_vprintf (gstrfuncs.c:507)
==6102== by 0xA966E88: g_strdup_printf (gstrfuncs.c:533)
==6102== by 0x6A66B8C: color_filters_read_globals (color_filters.c:704)
==6102== by 0x6A66FBE: color_filters_get (color_filters.c:317)
==6102== by 0x402313: fuzz_init (fuzzshark.c:237)
==6102== by 0x40252D: LLVMFuzzerInitialize (fuzzshark.c:322)
==6102== by 0x401E33: main (StandaloneFuzzTargetMain.c:125)
Change-Id: Ibc18edff6097eca736328810c903a151ddee22bc
Reviewed-on: https://code.wireshark.org/review/25553
Tested-by: Jakub Zawadzki <darkjames-ws@darkjames.pl>
Petri-Dish: Jakub Zawadzki <darkjames-ws@darkjames.pl>
Tested-by: Petri Dish Buildbot
Reviewed-by: Jakub Zawadzki <darkjames-ws@darkjames.pl>
Diffstat (limited to 'epan/color_filters.c')
| -rw-r--r-- | epan/color_filters.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/epan/color_filters.c b/epan/color_filters.c index da0dd96512..018263672e 100644 --- a/epan/color_filters.c +++ b/epan/color_filters.c @@ -715,6 +715,7 @@ color_filters_read_globals(gpointer user_data, gchar** err_msg, color_filter_add * There is no global filter file; treat that as equivalent to * that file existing bug being empty, and say we succeeded. */ + g_free(path); return TRUE; } |