diff options
| author | Guy Harris <guy@alum.mit.edu> | 2005-05-12 02:50:27 +0000 |
|---|---|---|
| committer | Guy Harris <guy@alum.mit.edu> | 2005-05-12 02:50:27 +0000 |
| commit | 3a8d46d8e9681257bec71391df01c43f1debf38d (patch) | |
| tree | 71b6f25b9a22ab7207de3c44f94e201b0677a60f /epan/addr_resolv.c | |
| parent | 92b1092937a6c12b6a16ed665a00b236233977d8 (diff) | |
Always set "*success" in "ipxnet_addr_lookup()" before returning (thanks
and a tip of the hat to GCC 4.0's interprocedural data flow analysis for
catching this one!).
svn path=/trunk/; revision=14353
Diffstat (limited to 'epan/addr_resolv.c')
| -rw-r--r-- | epan/addr_resolv.c | 8 |
1 files changed, 5 insertions, 3 deletions
diff --git a/epan/addr_resolv.c b/epan/addr_resolv.c index 81e8777652..7bf210fd45 100644 --- a/epan/addr_resolv.c +++ b/epan/addr_resolv.c @@ -1513,8 +1513,10 @@ static guint ipxnet_addr_lookup(const gchar *name, gboolean *success) for (i = 0; i < HASHIPXNETSIZE; i++) { tp = table[i]; while (tp) { - if (strcmp(tp->name, name) == 0) + if (strcmp(tp->name, name) == 0) { + *success = TRUE; return tp->addr; + } tp = tp->next; } } @@ -1522,8 +1524,8 @@ static guint ipxnet_addr_lookup(const gchar *name, gboolean *success) /* not in hash table : performs a file lookup */ if ((ipxnet = get_ipxnetbyname(name)) == NULL) { - *success = FALSE; - return 0; + *success = FALSE; + return 0; } /* add new entry in hash table */ |