diff options
author | Guy Harris <gharris@sonic.net> | 2021-02-14 12:54:42 -0800 |
---|---|---|
committer | Guy Harris <gharris@sonic.net> | 2021-02-14 14:43:42 -0800 |
commit | c0711693ab166b22664a68f01224c4ba682e1207 (patch) | |
tree | 136ac536c7ec89f94b337ef9c3ef3f13469e6f03 /dumpcap.c | |
parent | 3387eef8367ca7b16b5515635f79d971bde97c5e (diff) |
Enable -Wredundant-decls.
Add it to the default list of checks, and fix some errors it causes.
(Sadly, it doesn't work in CLang.)
Diffstat (limited to 'dumpcap.c')
-rw-r--r-- | dumpcap.c | 15 |
1 files changed, 10 insertions, 5 deletions
@@ -21,8 +21,17 @@ #include <netinet/in.h> #endif -#ifdef HAVE_GETOPT_H +/* + * If we have getopt_long() in the system library, include <getopt.h>. + * Otherwise, we're using our own getopt_long() (either because the + * system has getopt() but not getopt_long(), as with some UN*Xes, + * or because it doesn't even have getopt(), as with Windows), so + * include our getopt_long()'s header. + */ +#ifdef HAVE_GETOPT_LONG #include <getopt.h> +#else +#include <wsutil/wsgetopt.h> #endif #if defined(__APPLE__) && defined(__LP64__) @@ -39,10 +48,6 @@ #include <wsutil/socket.h> -#ifndef HAVE_GETOPT_LONG -#include "wsutil/wsgetopt.h" -#endif - #ifdef HAVE_LIBCAP # include <sys/prctl.h> # include <sys/capability.h> |