diff options
| author | Gilbert Ramirez <gram@alumni.rice.edu> | 2014-01-30 09:43:52 -0800 |
|---|---|---|
| committer | Alexis La Goutte <alexis.lagoutte@gmail.com> | 2014-02-03 09:26:10 +0000 |
| commit | 4cc694839d45d767f4880988da3b88389774b5db (patch) | |
| tree | 40905d9cf9345c56314cdfdfd04a65c6e25764df /doc | |
| parent | 479d27c69e46add652acbdd321fd3f88cfb50900 (diff) | |
Fix all -fstrict-alias warnings found by gcc 4.1.2
The majority of the fixes are for calls to uat_new(). Instead of
having each caller cast its private data to (void**), we use void*
in the uat_new() API itself. Inside uat_new(), we cast the void*
to void**.
Some dissectors use val64_string arrays, so a VALS64() macro was
added for those, to avoid using VALS(), which is useful only for
value_string arrays.
packet-mq.c was changed because dissect_nt_sid() requires
a char**, not a guint**. All other callers of dissect_nt_sid() use
char*'s (and take the address of it) for their local storage. So,
this was changed to follow the other practices.
A confusion between gint and absolute_time_display_e in packet-time.c
was cleared up.
The ugliest fix is the addition of ip6_guint8_to_str(), for exactly
one caller. The caller uses one type of ip6 address byte array,
while ip6_to_str() expects another. This new function is in place
until the various address implementations can be consolidated.
Add VALS64() to the developer documentation.
Change-Id: If93ff5c6c8c7cc3c9510d7fb78fa9108e4552805
Reviewed-on: https://code.wireshark.org/review/48
Reviewed-by: Evan Huus <eapache@gmail.com>
Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
Tested-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
Diffstat (limited to 'doc')
| -rw-r--r-- | doc/README.dissector | 8 |
1 files changed, 7 insertions, 1 deletions
diff --git a/doc/README.dissector b/doc/README.dissector index e2e9ae2b68..65a6ec145d 100644 --- a/doc/README.dissector +++ b/doc/README.dissector @@ -140,7 +140,7 @@ FIELDDISPLAY --For FT_UINT{8,16,24,32,64} and FT_INT{8,16,24,32,64): --For all other types: BASE_NONE -FIELDCONVERT VALS(x), RVALS(x), TFS(x), NULL +FIELDCONVERT VALS(x), VALS64(x), RVALS(x), TFS(x), NULL BITMASK Used to mask a field not 8-bit aligned or with a size other than a multiple of 8 bits FIELDDESCR A brief description of the field, or NULL. [Please do not use ""]. @@ -873,6 +873,12 @@ For hf[] array FT_(U)INT* fields that need a 'valstringname_ext' struct, the 'strings' field would be set to '&valstringname_ext'. Furthermore, the 'display' field must be ORed with 'BASE_EXT_STRING' (e.g. BASE_DEC|BASE_EXT_STRING). +-- val64_string + +val64_strings are like value_strings, except that the integer type +used is a guint64 (instead of guint32). Instead of using the VALS() +macro for the 'strings' field in the header_field_info struct array, +'VALS64()' is used. -- Ranges If the field has a numeric type that might logically fit in ranges of values |