diff options
| author | Guy Harris <guy@alum.mit.edu> | 2003-06-12 10:15:25 +0000 |
|---|---|---|
| committer | Guy Harris <guy@alum.mit.edu> | 2003-06-12 10:15:25 +0000 |
| commit | 48aa4ea7acf74801064c67997cac9f995f50a805 (patch) | |
| tree | cf938b6b41fe1ad98d01f4cf6a102d673aac3549 /doc | |
| parent | c7ce8b9a8b5feb0686e367490758a57ce44d2383 (diff) | |
Clarify the comment about not doing dissection work if "tree" is NULL,
to indicate what you should avoid doing *and* to indicate what you still
have to do (i.e., call subdissectors).
svn path=/trunk/; revision=7864
Diffstat (limited to 'doc')
| -rw-r--r-- | doc/README.developer | 12 |
1 files changed, 7 insertions, 5 deletions
diff --git a/doc/README.developer b/doc/README.developer index c2419334fe..9e83126368 100644 --- a/doc/README.developer +++ b/doc/README.developer @@ -1,4 +1,4 @@ -$Id: README.developer,v 1.74 2003/03/09 22:00:26 deniel Exp $ +$Id: README.developer,v 1.75 2003/06/12 10:15:25 guy Exp $ This file is a HOWTO for Ethereal developers. It describes how to start coding a Ethereal protocol dissector and the use some of the important functions and @@ -208,7 +208,7 @@ code inside is needed only if you are using the "snprintf()" function. -The "$Id: README.developer,v 1.74 2003/03/09 22:00:26 deniel Exp $" +The "$Id: README.developer,v 1.75 2003/06/12 10:15:25 guy Exp $" in the comment will be updated by CVS when the file is checked in; it will allow the RCS "ident" command to report which version of the file is currently checked out. @@ -218,7 +218,7 @@ version of the file is currently checked out. * Routines for PROTONAME dissection * Copyright 2000, YOUR_NAME <YOUR_EMAIL_ADDRESS> * - * $Id: README.developer,v 1.74 2003/03/09 22:00:26 deniel Exp $ + * $Id: README.developer,v 1.75 2003/06/12 10:15:25 guy Exp $ * * Ethereal - Network traffic analyzer * By Gerald Combs <gerald@ethereal.com> @@ -312,8 +312,10 @@ dissect_PROTOABBREV(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree) if (check_col(pinfo->cinfo, COL_INFO)) col_set_str(pinfo->cinfo, COL_INFO, "XXX Request"); -/* In the interest of speed, if "tree" is NULL, don't do any work not - necessary to generate protocol tree items. */ +/* In the interest of speed, if "tree" is NULL, avoid building a + protocol tree and adding stuff to it if possible. Note, + however, that you must call subdissectors regardless of whether + "tree" is NULL or not. */ if (tree) { /* NOTE: The offset and length values in the call to |