diff options
author | Gilbert Ramirez <gram@alumni.rice.edu> | 2000-03-23 05:43:57 +0000 |
---|---|---|
committer | Gilbert Ramirez <gram@alumni.rice.edu> | 2000-03-23 05:43:57 +0000 |
commit | adcb40405c3b2ac0f52041c7a5663be16834bc3d (patch) | |
tree | ac04fded27e50cf6d453a8e82864bb2fbe345664 /dfilter-scanner.l | |
parent | 0b8378e62213e09a1aa489188fb77ada50dabaa1 (diff) |
Remove small memory leak when converting strings that represent
byte sequences in display filters to byte arrays. This was caused
by a duplicate g_strdup() in my code.
svn path=/trunk/; revision=1745
Diffstat (limited to 'dfilter-scanner.l')
-rw-r--r-- | dfilter-scanner.l | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/dfilter-scanner.l b/dfilter-scanner.l index 6fcfe7d6f4..fceb0eae6a 100644 --- a/dfilter-scanner.l +++ b/dfilter-scanner.l @@ -3,7 +3,7 @@ /* dfilter-scanner.l * Scanner for display filters * - * $Id: dfilter-scanner.l,v 1.29 2000/02/15 21:01:55 gram Exp $ + * $Id: dfilter-scanner.l,v 1.30 2000/03/23 05:43:57 gram Exp $ * * Ethereal - Network traffic analyzer * By Gerald Combs <gerald@zing.org> @@ -327,13 +327,14 @@ byte_str_to_guint8_array(const char *s) { GByteArray *barray; guint8 val; - char *byte_str = g_strdup(s); /* local copy of string */ + char *byte_str; char *p, *str; barray = g_byte_array_new(); /* XXX - don't use global_df, but pass in pointer to GSList* */ global_df->list_of_byte_arrays = g_slist_append(global_df->list_of_byte_arrays, barray); + /* Local copy of string, since strtok will munge it */ byte_str = g_strdup(s); str = byte_str; while ((p = strtok(str, "-:."))) { |