diff options
| author | Gerald Combs <gerald@wireshark.org> | 2019-04-01 10:30:21 -0700 |
|---|---|---|
| committer | Gerald Combs <gerald@wireshark.org> | 2019-04-01 18:24:11 +0000 |
| commit | 2c00e5b4e4e4533476c08851037b99bbd27ecc26 (patch) | |
| tree | c4180deb8a3c3040a4cb3a3f417a95fee4505c8d /cmake | |
| parent | 43d2179e9658dde4ead4793d37a0507c379f302c (diff) | |
Fix our .chm titles.
HTML Help has trouble rendering both straight (') and curly (’) quotes
in its window titles. Make sure we remove them.
Bug: 15656
Change-Id: Ic7ab6652e285c11e50e4acb3fab4fcc12653778c
Reviewed-on: https://code.wireshark.org/review/32674
Petri-Dish: Gerald Combs <gerald@wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Gerald Combs <gerald@wireshark.org>
Diffstat (limited to 'cmake')
| -rw-r--r-- | cmake/modules/FindXSLTPROC.cmake | 9 |
1 files changed, 7 insertions, 2 deletions
diff --git a/cmake/modules/FindXSLTPROC.cmake b/cmake/modules/FindXSLTPROC.cmake index f7246b323c..e2a5d3fd8d 100644 --- a/cmake/modules/FindXSLTPROC.cmake +++ b/cmake/modules/FindXSLTPROC.cmake @@ -171,9 +171,14 @@ MACRO(XML2HHP _target_dep _guide _dbk_source) COMMAND ${CMAKE_COMMAND} -E make_directory ${_basedir}/${_gfxdir} COMMAND ${CMAKE_COMMAND} -E copy_directory ${CMAKE_CURRENT_SOURCE_DIR}/${_gfxdir} ${_basedir}/${_gfxdir} COMMAND ${CMAKE_COMMAND} -E copy_directory ${CMAKE_CURRENT_SOURCE_DIR}/common_graphics ${_basedir}/${_gfxdir} - # HTML Help doesn't render decimal character entities in the title. + # Dumb down our title. HTML Help can render most of our content + # correctly because we tell it to use the IE9 rendering engine in + # custom_layer_chm.xsl. However, this doesn't apply to the window + # title. Neither "’", "'", nor "’" will render correctly, so + # just remove everything between "Developer", "User", and their + # respective trailing "s"es. COMMAND ${PERL_EXECUTABLE} -p - -e "s|er’s Guide</title>|er's Guide</title>|" + -e "s|er.*s Guide</title>|ers Guide</title>|" < ${_dbk_source} > ${_docbook_plain_title} COMMAND ${XSLTPROC_EXECUTABLE} |