diff options
| author | João Valverde <j@v6e.pt> | 2021-07-26 17:22:36 +0100 |
|---|---|---|
| committer | João Valverde <j@v6e.pt> | 2021-09-17 00:43:54 +0100 |
| commit | 8df2a73594fbcc812f4ea22a72ab7a79bfb63dc3 (patch) | |
| tree | 7d30bc5be8e85c52c0dd295cb15cd717d5770dcb /capture_opts.h | |
| parent | 7462e76884942258bae110ead925f25ffa54e2a8 (diff) | |
Use the musl in-tree getopt_long() everywhere
Besides the obvious limitation of being unavailable on Windows,
the standard is vague about getopt() and getopt_long() has many
non-portable pitfalls and buggy implementations, that increase
the maintainance cost a lot. Also the GNU libc code currently
in the tree is not suited for embedding and is unmaintainable.
Own maintainership for getopt_long() and use the musl implementation
everywhere. This way we don't need to worry if optreset is available,
or if the $OPERATING_SYSTEM version behaves in subtly different ways.
The API is under the Wireshark namespace to avoid conflicts with
system headers.
Side-note, the Mingw-w64 9.0 getopt_long() implementation is buggy
with opterr and known to crash. In my experience it's a headache to
use the embedded getopt implementation if the system provides one.
Diffstat (limited to 'capture_opts.h')
| -rw-r--r-- | capture_opts.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/capture_opts.h b/capture_opts.h index 6573b34aaf..84379403f3 100644 --- a/capture_opts.h +++ b/capture_opts.h @@ -332,7 +332,7 @@ capture_opts_cleanup(capture_options *capture_opts); /* set a command line option value */ extern int -capture_opts_add_opt(capture_options *capture_opts, int opt, const char *optarg); +capture_opts_add_opt(capture_options *capture_opts, int opt, const char *ws_optarg); /* log content of capture_opts */ extern void |