diff options
author | Bill Meier <wmeier@newsguy.com> | 2008-02-23 19:59:38 +0000 |
---|---|---|
committer | Bill Meier <wmeier@newsguy.com> | 2008-02-23 19:59:38 +0000 |
commit | 8d4f01eea70c59acb0ef18acbc4f5254d4149e9f (patch) | |
tree | e87d1ef9d38dc5f7c31485b5f2c073d9f04188cc /capture_opts.c | |
parent | e6837f14d463998df7b8cb71d4408e60b8a73fb0 (diff) |
Ensure tshark/wireshark always get good err msgs from dumpcap:
1. Clean up dumpcap 'as a child' err msg handling so that:
- all err msgs are properly formatted when being sent
back to the parent.
- any log Critical, Warning, etc messages
are sent back to parent and are properly formatted.
2. Change handling of -w <...> slightly in capture_opts.c
so that wireshark provides a good error message if
there is a 'write permissions' issue on the file.
(Previously the error popup said only
"Child exited with status 2").
This fixes bug #2288.
Add some conditionalized DEBUG_CHILD_DUMPCAP code for
dumpcap debug logging to a file.
svn path=/trunk/; revision=24446
Diffstat (limited to 'capture_opts.c')
-rw-r--r-- | capture_opts.c | 7 |
1 files changed, 3 insertions, 4 deletions
diff --git a/capture_opts.c b/capture_opts.c index 600d8c0a8f..c958b59f1e 100644 --- a/capture_opts.c +++ b/capture_opts.c @@ -911,10 +911,9 @@ static gboolean capture_opts_output_to_pipe(const char *save_file, gboolean *is_ *is_pipe = TRUE; break; - default: /* couldn't stat it */ - cmdarg_err("Error testing whether capture file is a pipe: %s", - strerror(errno)); - return 2; + default: /* couldn't stat it */ + break; /* ignore: later attempt to open */ + /* will generate a nice msg */ } } } |