The heuristic for T.125 per is too week and we do not have a PER dissector

for T.125 so remove the test.
Remove unused hf entries.
Fixes bug 10350.

Change-Id: If28de7877388c669082f8c8a21dd63107d417fbf
Reviewed-on: https://code.wireshark.org/review/3458
Reviewed-by: Anders Broman <a.broman58@gmail.com>

1 files changed, 0 insertions, 32 deletions

diff --git a/asn1/t125/packet-t125-template.c b/asn1/t125/packet-t125-template.c
index 77d70b37f1..cc13f88a0a 100644
--- a/asn1/t125/packet-t125-template.c
+++ b/asn1/t125/packet-t125-template.c
@@ -49,9 +49,6 @@ static proto_tree *top_tree = NULL;
 /* Initialize the subtree pointers */
 static int ett_t125 = -1;
 
-static int hf_t125_connectData = -1;
-static int hf_t125_heur = -1;
-
 #include "packet-t125-ett.c"
 
 static heur_dissector_list_t t125_heur_subdissector_list;
@@ -93,12 +90,8 @@ dissect_t125_heur(tvbuff_t *tvb, packet_info *pinfo, proto_tree *parent_tree, vo
   gint8 ber_class;
   gboolean pc;
   gint32 tag;
-  guint32 choice_index = 100;
-  asn1_ctx_t asn1_ctx;
   volatile gboolean failed;
 
-  asn1_ctx_init(&asn1_ctx, ASN1_ENC_PER, TRUE, pinfo);
-
   /*
    * We must catch all the "ran past the end of the packet" exceptions
    * here and, if we catch one, just return FALSE.  It's too painful
@@ -121,23 +114,6 @@ dissect_t125_heur(tvbuff_t *tvb, packet_info *pinfo, proto_tree *parent_tree, vo
     return TRUE;
   }
 
-  failed = FALSE;
-  TRY {
-    /* or PER */
-    dissect_per_constrained_integer(tvb, 0, &asn1_ctx,
-                                    NULL, hf_t125_heur, 0, 42,
-                                    &choice_index, FALSE);
-  } CATCH_BOUNDS_ERRORS {
-    failed = TRUE;
-  } ENDTRY;
-
-  /* is this strong enough ? */
-  if (!failed && (choice_index <=42)) {
-    dissect_t125(tvb, pinfo, parent_tree, NULL);
-
-    return TRUE;
-  }
-
   return FALSE;
 }
 
@@ -147,14 +123,6 @@ void proto_register_t125(void) {
 
   /* List of fields */
   static hf_register_info hf[] = {
-    { &hf_t125_connectData,
-      { "connectData", "t125.connectData",
-        FT_NONE, BASE_NONE, NULL, 0,
-        NULL, HFILL }},
-    { &hf_t125_heur,
-      { "heuristic", "t125.heuristic",
-        FT_UINT32, BASE_DEC, NULL, 0,
-        NULL, HFILL }},
 #include "packet-t125-hfarr.c"
   };