aboutsummaryrefslogtreecommitdiffstats
path: root/asn1/ros
diff options
context:
space:
mode:
authorMichael Mann <mmann78@netscape.net>2013-06-14 12:44:50 +0000
committerMichael Mann <mmann78@netscape.net>2013-06-14 12:44:50 +0000
commit2dbf6c59a2f5d99d3dc8ea3d2ffa409ef2eb611a (patch)
treec021a26288d3d501a3dbb8de190cdc6a8e40ffa1 /asn1/ros
parent875040ec1e304110b2a7f1a6e9ead855d3be2e6f (diff)
Remove check_col() from ASN.1 dissectors
svn path=/trunk/; revision=49927
Diffstat (limited to 'asn1/ros')
-rw-r--r--asn1/ros/packet-ros-template.c8
-rw-r--r--asn1/ros/ros-err.cnf2
-rw-r--r--asn1/ros/ros-inv.cnf2
-rw-r--r--asn1/ros/ros-rej.cnf2
-rw-r--r--asn1/ros/ros-res.cnf2
-rw-r--r--asn1/ros/ros.cnf19
6 files changed, 12 insertions, 23 deletions
diff --git a/asn1/ros/packet-ros-template.c b/asn1/ros/packet-ros-template.c
index b8e4741022..c1277bae8c 100644
--- a/asn1/ros/packet-ros-template.c
+++ b/asn1/ros/packet-ros-template.c
@@ -193,11 +193,9 @@ static gboolean ros_try_string(const char *oid, tvbuff_t *tvb, packet_info *pinf
opname = val_to_str(opcode_lcl, lookup, "Unknown opcode (%d)");
- if (check_col(pinfo->cinfo, COL_INFO)) {
- col_set_str(pinfo->cinfo, COL_INFO, opname);
- if(suffix)
- col_append_str(pinfo->cinfo, COL_INFO, suffix);
- }
+ col_set_str(pinfo->cinfo, COL_INFO, opname);
+ if(suffix)
+ col_append_str(pinfo->cinfo, COL_INFO, suffix);
(*opdissector)(tvb, pinfo, ros_tree, NULL);
diff --git a/asn1/ros/ros-err.cnf b/asn1/ros/ros-err.cnf
index 4b5ec2a86a..5ec7e0e319 100644
--- a/asn1/ros/ros-err.cnf
+++ b/asn1/ros/ros-err.cnf
@@ -31,7 +31,7 @@
if (actx->rose_ctx->apdu_depth >= 0)
proto_item_append_text(proto_item_get_parent_nth(proto_tree_get_parent(tree), actx->rose_ctx->apdu_depth), " %s", descr);
- if (actx->rose_ctx->fillin_info && check_col(actx->pinfo->cinfo, COL_INFO))
+ if (actx->rose_ctx->fillin_info)
col_append_str(actx->pinfo->cinfo, COL_INFO, descr);
if (actx->rose_ctx->fillin_ptr)
g_strlcat(actx->rose_ctx->fillin_ptr, descr, actx->rose_ctx->fillin_buf_size);
diff --git a/asn1/ros/ros-inv.cnf b/asn1/ros/ros-inv.cnf
index e2a61994cb..0e7ba0390b 100644
--- a/asn1/ros/ros-inv.cnf
+++ b/asn1/ros/ros-inv.cnf
@@ -32,7 +32,7 @@
if (actx->rose_ctx->apdu_depth >= 0)
proto_item_append_text(proto_item_get_parent_nth(proto_tree_get_parent(tree), actx->rose_ctx->apdu_depth), " %s", descr);
- if (actx->rose_ctx->fillin_info && check_col(actx->pinfo->cinfo, COL_INFO))
+ if (actx->rose_ctx->fillin_info)
col_append_str(actx->pinfo->cinfo, COL_INFO, descr);
if (actx->rose_ctx->fillin_ptr)
g_strlcat(actx->rose_ctx->fillin_ptr, descr, actx->rose_ctx->fillin_buf_size);
diff --git a/asn1/ros/ros-rej.cnf b/asn1/ros/ros-rej.cnf
index a651953dec..02b97f582f 100644
--- a/asn1/ros/ros-rej.cnf
+++ b/asn1/ros/ros-rej.cnf
@@ -12,7 +12,7 @@
if (actx->rose_ctx->apdu_depth >= 0)
proto_item_append_text(proto_item_get_parent_nth(proto_tree_get_parent(tree), actx->rose_ctx->apdu_depth), " %s", descr);
- if (actx->rose_ctx->fillin_info && check_col(actx->pinfo->cinfo, COL_INFO))
+ if (actx->rose_ctx->fillin_info)
col_append_str(actx->pinfo->cinfo, COL_INFO, descr);
if (actx->rose_ctx->fillin_ptr)
g_strlcat(actx->rose_ctx->fillin_ptr, descr, actx->rose_ctx->fillin_buf_size);
diff --git a/asn1/ros/ros-res.cnf b/asn1/ros/ros-res.cnf
index f02a779cc5..d9ab23c421 100644
--- a/asn1/ros/ros-res.cnf
+++ b/asn1/ros/ros-res.cnf
@@ -32,7 +32,7 @@
if (actx->rose_ctx->apdu_depth >= 0)
proto_item_append_text(proto_item_get_parent_nth(proto_tree_get_parent(tree), actx->rose_ctx->apdu_depth), " %s", descr);
- if (actx->rose_ctx->fillin_info && check_col(actx->pinfo->cinfo, COL_INFO))
+ if (actx->rose_ctx->fillin_info)
col_append_str(actx->pinfo->cinfo, COL_INFO, descr);
if (actx->rose_ctx->fillin_ptr)
g_strlcat(actx->rose_ctx->fillin_ptr, descr, actx->rose_ctx->fillin_buf_size);
diff --git a/asn1/ros/ros.cnf b/asn1/ros/ros.cnf
index 589737d1df..3ad482bbcc 100644
--- a/asn1/ros/ros.cnf
+++ b/asn1/ros/ros.cnf
@@ -158,8 +158,7 @@ Reject/problem/returnResult rejectResult
}
#.FN_BODY ROS/reject
- if(check_col(actx->pinfo->cinfo, COL_INFO))
- col_set_str(actx->pinfo->cinfo, COL_INFO, "Reject");
+ col_set_str(actx->pinfo->cinfo, COL_INFO, "Reject");
%(DEFAULT_BODY)s
#.FN_PARS GeneralProblem
@@ -170,9 +169,7 @@ Reject/problem/returnResult rejectResult
%(DEFAULT_BODY)s
- if (check_col(actx->pinfo->cinfo, COL_INFO)) {
- col_append_fstr(actx->pinfo->cinfo, COL_INFO, " %%s", val_to_str(problem, ros_GeneralProblem_vals, "GeneralProblem(%%d)"));
- }
+ col_append_fstr(actx->pinfo->cinfo, COL_INFO, " %%s", val_to_str(problem, ros_GeneralProblem_vals, "GeneralProblem(%%d)"));
#.FN_PARS InvokeProblem
VAL_PTR = &problem
@@ -182,9 +179,7 @@ Reject/problem/returnResult rejectResult
%(DEFAULT_BODY)s
- if (check_col(actx->pinfo->cinfo, COL_INFO)) {
- col_append_fstr(actx->pinfo->cinfo, COL_INFO, " %%s", val_to_str(problem, ros_InvokeProblem_vals, "InvokeProblem(%%d)"));
- }
+ col_append_fstr(actx->pinfo->cinfo, COL_INFO, " %%s", val_to_str(problem, ros_InvokeProblem_vals, "InvokeProblem(%%d)"));
#.FN_PARS ReturnResultProblem
VAL_PTR = &problem
@@ -194,9 +189,7 @@ Reject/problem/returnResult rejectResult
%(DEFAULT_BODY)s
- if (check_col(actx->pinfo->cinfo, COL_INFO)) {
- col_append_fstr(actx->pinfo->cinfo, COL_INFO, " %%s", val_to_str(problem, ros_ReturnResultProblem_vals, "ReturnResultProblem(%%d)"));
- }
+ col_append_fstr(actx->pinfo->cinfo, COL_INFO, " %%s", val_to_str(problem, ros_ReturnResultProblem_vals, "ReturnResultProblem(%%d)"));
#.FN_PARS ReturnErrorProblem
VAL_PTR = &problem
@@ -206,8 +199,6 @@ Reject/problem/returnResult rejectResult
%(DEFAULT_BODY)s
- if (check_col(actx->pinfo->cinfo, COL_INFO)) {
- col_append_fstr(actx->pinfo->cinfo, COL_INFO, " %%s", val_to_str(problem, ros_ReturnErrorProblem_vals, "ReturnErrorProblem(%%d)"));
- }
+ col_append_fstr(actx->pinfo->cinfo, COL_INFO, " %%s", val_to_str(problem, ros_ReturnErrorProblem_vals, "ReturnErrorProblem(%%d)"));
#.END