diff options
author | Michael Mann <mmann78@netscape.net> | 2014-08-08 09:19:29 -0400 |
---|---|---|
committer | Michael Mann <mmann78@netscape.net> | 2014-08-09 01:57:08 +0000 |
commit | cd02af56a1e39c66b44fd7957aff3b7b77a59e9d (patch) | |
tree | 4a3e859751bb73268115a607e9dffcec008bb411 /asn1/dap/packet-dap-template.c | |
parent | bb15274a4a82fcab1c06935fa1e249f436420a02 (diff) |
Eliminate (almost all) proto_tree_add_text calls from ASN.1 dissectors.
This mostly involved adding expert info capabilities to many of the dissectors so that they could correctly flag error conditions.
Only remaining proto_tree_add_text calls are in H248.cnf, which has a convoluted way of using hf_ data to make its tree.
Change-Id: I6412150c2ec1977d7fa38f3f0ed416680bdfb141
Reviewed-on: https://code.wireshark.org/review/3500
Petri-Dish: Michael Mann <mmann78@netscape.net>
Reviewed-by: Michael Mann <mmann78@netscape.net>
Diffstat (limited to 'asn1/dap/packet-dap-template.c')
-rw-r--r-- | asn1/dap/packet-dap-template.c | 11 |
1 files changed, 11 insertions, 0 deletions
diff --git a/asn1/dap/packet-dap-template.c b/asn1/dap/packet-dap-template.c index 32a008216e..d2888c7edb 100644 --- a/asn1/dap/packet-dap-template.c +++ b/asn1/dap/packet-dap-template.c @@ -26,6 +26,7 @@ #include <glib.h> #include <epan/packet.h> #include <epan/prefs.h> +#include <epan/expert.h> #include <epan/oids.h> #include <epan/asn1.h> @@ -68,6 +69,8 @@ static int proto_dap = -1; static gint ett_dap = -1; #include "packet-dap-ett.c" +static expert_field ei_dap_anonymous = EI_INIT; + #include "packet-dap-val.h" #include "packet-dap-table.c" /* operation and error codes */ @@ -102,7 +105,13 @@ void proto_register_dap(void) { &ett_dap, #include "packet-dap-ettarr.c" }; + + static ei_register_info ei[] = { + { &ei_dap_anonymous, { "dap.anonymous", PI_PROTOCOL, PI_NOTE, "Anonymous", EXPFILL }}, + }; + module_t *dap_module; + expert_module_t* expert_dap; /* Register protocol */ proto_dap = proto_register_protocol(PNAME, PSNAME, PFNAME); @@ -110,6 +119,8 @@ void proto_register_dap(void) { /* Register fields and subtrees */ proto_register_field_array(proto_dap, hf, array_length(hf)); proto_register_subtree_array(ett, array_length(ett)); + expert_dap = expert_register_protocol(proto_dap); + expert_register_field_array(expert_dap, ei, array_length(ei)); /* Register our configuration options for DAP, particularly our port */ |