diff options
| author | Ronnie Sahlberg <ronnie_sahlberg@ozemail.com.au> | 2006-09-12 12:08:34 +0000 |
|---|---|---|
| committer | Ronnie Sahlberg <ronnie_sahlberg@ozemail.com.au> | 2006-09-12 12:08:34 +0000 |
| commit | 4919409df7c5698ecee34e68611383d2203e125e (patch) | |
| tree | c36710d07b3a73760b5884641680684155216ee2 /AUTHORS | |
| parent | 073483df4547ec8383a17b5924b03789d2b6d7fa (diff) | |
from Taner Kurtulus and Menno Andriesse
Hi folks,
We think we've found a bug in STANAG 5066 SIS layer dissector.
Problem is at S_EXPEDITED_UNIDATA_INDICATION S_Prim's parser
and occurs when we receive a U_PDU via expedited unidata channel.
Dissector tries to parse first 2 bytes of U_PDU as a header size of type
21 s_prim (S_UNIDATA_INDICATION). But, this is not an wanted process on
that parser. Maybe, it was forgotten unchanged from
S_UNIDATA_INDICATION dissector while copying it. So it shows
data (U_PDU) 2 bytes short. Moreover, if data is just 1-byte, TCP datagrams
receive TCP checksum error.
Confirmed.
It was indeed a "copy-paste-did not edit correctly" bug.
While going over the code once more, I found:
1 - One bug in the heuristic. (Changed '&&' to '||')
2 - One to-do that was already done. (Removed the /* TODO */)
3 - One to-do that is now done. ;-)
svn path=/trunk/; revision=19210
Diffstat (limited to 'AUTHORS')
| -rw-r--r-- | AUTHORS | 1 |
1 files changed, 1 insertions, 0 deletions
@@ -2654,6 +2654,7 @@ Christoph Werle <Christoph.Werle [AT] ira.uka.de> Aaron Christensen <aaronmf [AT] gmail.com> Ian Abel <ianabel [AT] mxtelecom.com> Bryant Eastham <beastham [AT] slc.mew.com> +Taner Kurtulus <taner.kurtulus [AT] tubitak.gov.tr> Alain Magloire <alainm[AT]rcsm.ece.mcgill.ca> was kind enough to give his permission to use his version of snprintf.c. |