diff options
author | Jeff Morriss <jeff.morriss@ulticom.com> | 2011-04-05 02:18:28 +0000 |
---|---|---|
committer | Jeff Morriss <jeff.morriss@ulticom.com> | 2011-04-05 02:18:28 +0000 |
commit | a148a936b180524ac44a4b4f195d8ea6774bf216 (patch) | |
tree | bc6702c6b4f97c85e877f9814108cd07df485861 /AUTHORS | |
parent | b8acdc8ee042ece5e8ad9adf629405006ee9fef1 (diff) |
From Felix Kraemer: fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5694 :
This patch adds the capability to create BACnet statistics trees.
Find the respective menu items under 'Statistics->BACnet'.
Packets can be sorted by different criteria:
- Src/Dst IP adresses
- Instance ID
- Object Type
- Service
From me:
- Don't use C++/C99-style comments.
- Name variables for tick_stat_node() don't need to be static.
- Change updateBacnetInfoValue() to require 'data' to be ep_ allocated. Change
the couple of calls that did not send in ep_ allocated data to do so.
- Change one or two functions to be static.
- Do not use (memory-unsafe) g_sprintf().
- Use ep_strconcat() instead of leaking memory with g_strconcat().
- Put back one if(tree) that doesn't appear to do any harm.
- Remove variable declarations and #includes from the header file.
svn path=/trunk/; revision=36468
Diffstat (limited to 'AUTHORS')
-rw-r--r-- | AUTHORS | 4 |
1 files changed, 4 insertions, 0 deletions
@@ -3140,6 +3140,10 @@ Herbert Lischka <herbert [AT] lischka-berlin.de> { BACNET dissector fixes and enhancements } +Felix Krämer <sauter-cumulus [AT] de.sauter-bc.com> { + Stats Tree for BACapp dissector +} + Tom Hughes <tom [AT] compton.nu> { FCGI dissector } |