diff options
| author | Bill Meier <wmeier@newsguy.com> | 2011-04-13 21:27:08 +0000 |
|---|---|---|
| committer | Bill Meier <wmeier@newsguy.com> | 2011-04-13 21:27:08 +0000 |
| commit | 9b36f03fc904969484c7b976e16ba2fa7c34fc35 (patch) | |
| tree | 5892f8ef1dd5ba2bea6935e1d1f1fc44efb85893 | |
| parent | 8c4a4c09b94181ca117038c2b8c87106a8569d56 (diff) | |
Don't assign to a proto_item * if the value won't be used: Coverity 1054-1056.
svn path=/trunk/; revision=36631
| -rw-r--r-- | epan/dissectors/packet-tcp.c | 9 |
1 files changed, 4 insertions, 5 deletions
diff --git a/epan/dissectors/packet-tcp.c b/epan/dissectors/packet-tcp.c index bb57125986..43c42a8caa 100644 --- a/epan/dissectors/packet-tcp.c +++ b/epan/dissectors/packet-tcp.c @@ -2237,9 +2237,8 @@ static void dissect_tcpopt_sack_perm(const ip_tcp_opt *optp _U_, tvbuff_t *tvb, int offset, guint optlen, packet_info *pinfo, proto_tree *opt_tree) { - proto_item *hidden_item; - hidden_item = proto_tree_add_boolean(opt_tree, hf_tcp_option_sack_perm, tvb, offset, - optlen, TRUE); + proto_tree_add_boolean(opt_tree, hf_tcp_option_sack_perm, tvb, offset, + optlen, TRUE); tcp_info_append_uint(pinfo, "SACK_PERM", TRUE); } @@ -2572,7 +2571,7 @@ dissect_tcpopt_scps(const ip_tcp_opt *optp, tvbuff_t *tvb, if (flow->scps_capable != 1) { /* There was no SCPS capabilities option preceeding this */ - tf = proto_tree_add_uint_format(opt_tree, hf_tcp_option_scps_vector, + proto_tree_add_uint_format(opt_tree, hf_tcp_option_scps_vector, tvb, offset, optlen, 0, "%s: (%d %s)", "Illegal SCPS Extended Capabilities", (optlen), @@ -3070,7 +3069,7 @@ dissect_tcpopt_rvbd_probe(const ip_tcp_opt *optp _U_, tvbuff_t *tvb, int offset, break; case PROBE_RST: - flag_pi = proto_tree_add_item(field_tree, hf_tcp_option_rvbd_probe_flags, + proto_tree_add_item(field_tree, hf_tcp_option_rvbd_probe_flags, tvb, offset + PROBE_V2_INFO_OFFSET, 1, FALSE); break; |