diff options
| author | Martin Mathieson <martin.r.mathieson@googlemail.com> | 2017-12-03 20:26:05 +0000 |
|---|---|---|
| committer | Anders Broman <a.broman58@gmail.com> | 2017-12-04 05:49:49 +0000 |
| commit | 5350fd741f0ceafdea69b3ec6b04565b47146822 (patch) | |
| tree | 33a5ceb3df5534c0a7f8ee8e2e4543ba018502c5 | |
| parent | f411ab39886c5b372371b939311d9cab54a9a183 (diff) | |
RLC LTE graph: add comments clarifying tracer limitation
Change-Id: Ib6a79689ced9377b1ac00513810db2e86d26d83f
Reviewed-on: https://code.wireshark.org/review/24690
Petri-Dish: Martin Mathieson <martin.r.mathieson@googlemail.com>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
| -rw-r--r-- | ui/qt/lte_rlc_graph_dialog.cpp | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/ui/qt/lte_rlc_graph_dialog.cpp b/ui/qt/lte_rlc_graph_dialog.cpp index b395d62edd..71478dddfb 100644 --- a/ui/qt/lte_rlc_graph_dialog.cpp +++ b/ui/qt/lte_rlc_graph_dialog.cpp @@ -304,6 +304,8 @@ void LteRlcGraphDialog::fillGraph() mouseMoved(NULL); resetAxes(); + // This is why, in mouseMoved(), we only match the entries + // corresponding to data segments (base_graph_)... tracer_->setGraph(base_graph_); // XXX QCustomPlot doesn't seem to draw any sort of focus indicator. @@ -597,6 +599,9 @@ void LteRlcGraphDialog::mouseMoved(QMouseEvent *event) tracer_->setVisible(true); packet_num_ = packet_seg->num; + // N.B. because tracer only looks up entries in base_graph_, + // we know that packet_seg will be a data segment, so no need to check + // iscontrolPDU or isResegmented fields. hint += tr("%1 %2 (%3s seq %4 len %5)") .arg(cap_file_.capFile() ? tr("Click to select packet") : tr("Packet")) .arg(packet_num_) |