diff options
| author | Guy Harris <guy@alum.mit.edu> | 2014-11-23 12:30:59 -0800 |
|---|---|---|
| committer | Guy Harris <guy@alum.mit.edu> | 2014-11-23 20:53:11 +0000 |
| commit | 4d55e1f455bc2c087b74d237a1da7914c2cfb915 (patch) | |
| tree | 90905e6a7f86bf31c75bfc75e13313d1360bb184 | |
| parent | da5487ff495a6c996d588b76e7d3a85d42d1d8c2 (diff) | |
Presumably the intent is to dump *non*-dummy entries.
I.e., presumably the intent is to dump *resolved* hosts, rather than
*unresolved* hosts where there's no known host name and the name field
is a string form of the address (the premise being that looking the
address up in the hash table repeatedly, and using the already-generated
string, will be faster than generating the string repeatedly).
Change-Id: Iad1beb1d5f9cd9ed92bad5386111cb659614ee4d
Reviewed-on: https://code.wireshark.org/review/5455
Reviewed-by: Guy Harris <guy@alum.mit.edu>
| -rw-r--r-- | ui/cli/tap-hosts.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/ui/cli/tap-hosts.c b/ui/cli/tap-hosts.c index 6954a8c54b..aa53ec0048 100644 --- a/ui/cli/tap-hosts.c +++ b/ui/cli/tap-hosts.c @@ -51,7 +51,7 @@ ipv4_hash_table_print_resolved(gpointer key _U_, gpointer value, gpointer user_d { hashipv4_t *ipv4_hash_table_entry = (hashipv4_t *)value; - if ((ipv4_hash_table_entry->flags & DUMMY_ADDRESS_ENTRY) == DUMMY_ADDRESS_ENTRY) { + if (!(ipv4_hash_table_entry->flags & DUMMY_ADDRESS_ENTRY)) { printf("%s\t%s\n", ipv4_hash_table_entry->ip, ipv4_hash_table_entry->name); @@ -63,7 +63,7 @@ ipv6_hash_table_print_resolved(gpointer key _U_, gpointer value, gpointer user_d { hashipv6_t *ipv6_hash_table_entry = (hashipv6_t *)value; - if ((ipv6_hash_table_entry->flags & DUMMY_ADDRESS_ENTRY) == DUMMY_ADDRESS_ENTRY) { + if (!(ipv6_hash_table_entry->flags & DUMMY_ADDRESS_ENTRY)) { printf("%s\t%s\n", ipv6_hash_table_entry->ip6, ipv6_hash_table_entry->name); |