diff options
| author | Guy Harris <guy@alum.mit.edu> | 2020-04-23 20:34:55 -0700 |
|---|---|---|
| committer | Guy Harris <gharris@sonic.net> | 2020-04-24 03:36:03 +0000 |
| commit | 4b503b1f0e8984059f8541f62ec76e7a65443a37 (patch) | |
| tree | c1614e900c19943d01aec88b463a188622d2c1a2 | |
| parent | 485476d0d2abaeca35473192011063572a7b9ecd (diff) | |
Add a comment explaining why we treat OUI_HP_2 specially.
Change-Id: If5c7cd0bb673767b95db8981018e2e67135fef63
Reviewed-on: https://code.wireshark.org/review/36912
Reviewed-by: Guy Harris <gharris@sonic.net>
| -rw-r--r-- | epan/dissectors/packet-llc.c | 15 |
1 files changed, 15 insertions, 0 deletions
diff --git a/epan/dissectors/packet-llc.c b/epan/dissectors/packet-llc.c index be8d3e7a77..3eaf473bdc 100644 --- a/epan/dissectors/packet-llc.c +++ b/epan/dissectors/packet-llc.c @@ -519,6 +519,21 @@ dissect_snap(tvbuff_t *tvb, int offset, packet_info *pinfo, proto_tree *tree, switch (oui) { case OUI_HP_2: + /* + * We don't use the standard SNAP OUI mechanism here + * because that only calls the subdissector for + * information frames, and, according to the HP document + * at + * + * http://www.hp.com/sbso/bus_protect/teaming.pdf + * + * the heartbeats are sent to 03-00-C7-00-00-EE in SNAP + * frames in unnumbered TEST frames, not information + * frames (numbered or unnumbered). + * + * See the comment in epan/dissectors/packet-hpteam.c + * for more details. + */ oui_info = get_snap_oui_info(oui); hf = *oui_info->field_info->p_id; proto_tree_add_uint(snap_tree, hf, tvb, offset+3, 2, etype); |