aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorPascal Quantin <pascal.quantin@gmail.com>2017-08-10 17:36:07 +0200
committerPascal Quantin <pascal.quantin@gmail.com>2017-08-10 15:54:24 +0000
commit21cb715dbea71c7865107503fddf3ae24010fe85 (patch)
tree6d4d368434c4bd60578816cb47e05a01edb8d2cc
parentde2a738cbd4df919b8bdb3e6c824d55670869f36 (diff)
SML: fix checksum verification
The checksum is stored in little endian format. Regression introduced in gad6fc87d64 Change-Id: Ic5dd58f645fbe9d791b367d5777e07acb135d38c Reviewed-on: https://code.wireshark.org/review/23034 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
-rw-r--r--epan/dissectors/packet-sml.c8
1 files changed, 4 insertions, 4 deletions
diff --git a/epan/dissectors/packet-sml.c b/epan/dissectors/packet-sml.c
index 30001024af..97bf576ffd 100644
--- a/epan/dissectors/packet-sml.c
+++ b/epan/dissectors/packet-sml.c
@@ -2395,11 +2395,11 @@ static void dissect_sml_file(tvbuff_t *tvb, packet_info *pinfo, gint *offset, pr
}
proto_tree_add_checksum(crc16_tree, tvb, *offset, hf_sml_crc16, hf_sml_crc16_status, &ei_sml_crc_error, pinfo, crc_check,
- ENC_BIG_ENDIAN, PROTO_CHECKSUM_VERIFY);
+ ENC_LITTLE_ENDIAN, PROTO_CHECKSUM_VERIFY);
}
else {
proto_tree_add_checksum(crc16_tree, tvb, *offset, hf_sml_crc16, hf_sml_crc16_status, &ei_sml_crc_error, pinfo, 0,
- ENC_BIG_ENDIAN, PROTO_CHECKSUM_NO_FLAGS);
+ ENC_LITTLE_ENDIAN, PROTO_CHECKSUM_NO_FLAGS);
}
*offset+=data;
@@ -2469,11 +2469,11 @@ static void dissect_sml_file(tvbuff_t *tvb, packet_info *pinfo, gint *offset, pr
crc_check = crc16_ccitt_tvb_offset(tvb,*offset-crc_file_len, crc_file_len);
proto_tree_add_checksum(msgend_tree, tvb, *offset, hf_sml_crc16, hf_sml_crc16_status, &ei_sml_crc_error, pinfo, crc_check,
- ENC_BIG_ENDIAN, PROTO_CHECKSUM_VERIFY);
+ ENC_LITTLE_ENDIAN, PROTO_CHECKSUM_VERIFY);
}
else {
proto_tree_add_checksum(msgend_tree, tvb, *offset, hf_sml_crc16, hf_sml_crc16_status, &ei_sml_crc_error, pinfo, crc_check,
- ENC_BIG_ENDIAN, PROTO_CHECKSUM_NO_FLAGS);
+ ENC_LITTLE_ENDIAN, PROTO_CHECKSUM_NO_FLAGS);
}
*offset+=2;