diff options
| author | Peter Wu <peter@lekensteyn.nl> | 2019-11-22 02:08:51 +0000 |
|---|---|---|
| committer | Anders Broman <a.broman58@gmail.com> | 2019-11-22 05:08:52 +0000 |
| commit | 06afefad91804f33c4c825764cb045bb50c3842c (patch) | |
| tree | 13d230e5d641599da167ac6e274d3792353e6150 | |
| parent | b22a63d025ca6f33e6aa0cbc0a80a9478efde65d (diff) | |
QUIC: atag is an array of bytes, not pointers
The allocated buffer is unnecessarily large due to the array storing
pointers instead of bytes. This wastes memory but has no other bad
side-effects. It was not caught by the compiler because the users accept
void pointers. I only noticed it in the debugger.
Change-Id: I9690b5481289d17fed34512b6a32915c3a30d36b
Reviewed-on: https://code.wireshark.org/review/35184
Petri-Dish: Peter Wu <peter@lekensteyn.nl>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
| -rw-r--r-- | epan/dissectors/packet-quic.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/epan/dissectors/packet-quic.c b/epan/dissectors/packet-quic.c index a42244fb6c..13aca0fc2f 100644 --- a/epan/dissectors/packet-quic.c +++ b/epan/dissectors/packet-quic.c @@ -1346,7 +1346,7 @@ quic_decrypt_message(quic_cipher *cipher, tvbuff_t *head, guint header_length, guint8 *header; guint8 nonce[TLS13_AEAD_NONCE_LENGTH]; guint8 *buffer; - guint8 *atag[16]; + guint8 atag[16]; guint buffer_length; const guchar **error = &result->error; |