aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorEvan Huus <eapache@gmail.com>2013-12-23 21:19:34 +0000
committerEvan Huus <eapache@gmail.com>2013-12-23 21:19:34 +0000
commite8057786921920130dbcaef548b0f366654694ff (patch)
tree8136281d8a4741d0aaecb850dc7709095e36ff99
parenta0321ddb9dc826a8c39f2609e893d3045dd3d165 (diff)
Avoid using ephemeral memory in register routines.
svn path=/trunk/; revision=54423
-rw-r--r--plugins/asn1/packet-asn1.c6
-rw-r--r--plugins/opcua/opcua.c5
2 files changed, 7 insertions, 4 deletions
diff --git a/plugins/asn1/packet-asn1.c b/plugins/asn1/packet-asn1.c
index d505b721d4..941cb16be3 100644
--- a/plugins/asn1/packet-asn1.c
+++ b/plugins/asn1/packet-asn1.c
@@ -5306,9 +5306,9 @@ proto_register_asn1(void) {
"ASN.1 messages will be read",
10, &global_sctp_port_asn1);
#else
- range_convert_str(&global_tcp_ports_asn1, ep_strdup_printf("%u", TCP_PORT_ASN1), 65535);
- range_convert_str(&global_udp_ports_asn1, ep_strdup_printf("%u", UDP_PORT_ASN1), 65535);
- range_convert_str(&global_sctp_ports_asn1, ep_strdup_printf("%u", SCTP_PORT_ASN1), 65535);
+ range_convert_str(&global_tcp_ports_asn1, "0", 65535);
+ range_convert_str(&global_udp_ports_asn1, "0", 65535);
+ range_convert_str(&global_sctp_ports_asn1, "0", 65535);
prefs_register_range_preference(asn1_module, "tcp_ports",
"ASN.1 TCP Ports",
diff --git a/plugins/opcua/opcua.c b/plugins/opcua/opcua.c
index 2e0d87003d..d76cd36652 100644
--- a/plugins/opcua/opcua.c
+++ b/plugins/opcua/opcua.c
@@ -129,6 +129,7 @@ static const char* g_szMessageTypes[] =
*/
void proto_register_opcua(void)
{
+ char *tmp;
static hf_register_info hf[] =
{
@@ -195,7 +196,9 @@ void proto_register_opcua(void)
proto_register_subtree_array(ett, array_length(ett));
- range_convert_str(&global_tcp_ports_opcua, ep_strdup_printf("%u", OPCUA_PORT), 65535);
+ tmp = g_strdup_printf("%d", OPCUA_PORT);
+ range_convert_str(&global_tcp_ports_opcua, tmp, 65535);
+ g_free(tmp);
reassembly_table_init(&opcua_reassembly_table,
&addresses_reassembly_table_functions);