diff options
| author | Michal Labedzki <michal.labedzki@tieto.com> | 2015-09-25 11:16:55 +0200 |
|---|---|---|
| committer | Michal Labedzki <michal.labedzki@tieto.com> | 2015-10-17 09:20:03 +0000 |
| commit | 5f3370a2a6734c9f80acfb8c51a299c1c62f9e46 (patch) | |
| tree | fbad65131422b9a4bb1170c865d65b997bf45fa9 | |
| parent | fbef9e630ba87850c44dafd2280689d350912d1a (diff) | |
Make incomplete dissectors bytes more visible
Skipped bytes is now visible in Bytes pane.
Change-Id: I17f62caf183d9f871f969869363d9831d810f4d5
Reviewed-on: https://code.wireshark.org/review/11027
Petri-Dish: Michal Labedzki <michal.labedzki@tieto.com>
Reviewed-by: Jörg Mayer <jmayer@loplof.de>
Reviewed-by: Dario Lombardo <lomato@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Michal Labedzki <michal.labedzki@tieto.com>
| -rw-r--r-- | epan/dissectors/packet-frame.c | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/epan/dissectors/packet-frame.c b/epan/dissectors/packet-frame.c index bc1476bdfd..5912f2570f 100644 --- a/epan/dissectors/packet-frame.c +++ b/epan/dissectors/packet-frame.c @@ -654,8 +654,7 @@ dissect_frame(tvbuff_t *tvb, packet_info *pinfo, proto_tree *parent_tree, void* "(0x%.4X+%u)", (fi ? fi->hfinfo->abbrev : "[unknown]"), pinfo->fd->num, i, i - i % 16, i % 16); - expert_add_info_format(pinfo, tree, &ei_incomplete, - "Undecoded byte number: %u (0x%.4X+%u)", i, i - i % 16, i % 16); + proto_tree_add_expert_format(tree, pinfo, &ei_incomplete, tvb, i, 1, "Undecoded byte number: %u (0x%.4X+%u)", i, i - i % 16, i % 16); } } } @@ -854,7 +853,7 @@ proto_register_frame(void) static ei_register_info ei[] = { { &ei_comments_text, { "frame.comment.expert", PI_COMMENTS_GROUP, PI_COMMENT, "Formatted comment", EXPFILL }}, { &ei_arrive_time_out_of_range, { "frame.time_invalid", PI_SEQUENCE, PI_NOTE, "Arrival Time: Fractional second out of range (0-1000000000)", EXPFILL }}, - { &ei_incomplete, { "frame.incomplete", PI_UNDECODED, PI_WARN, "Incomplete dissector", EXPFILL }} + { &ei_incomplete, { "frame.incomplete", PI_UNDECODED, PI_NOTE, "Incomplete dissector", EXPFILL }} }; module_t *frame_module; |