diff options
| author | John Thacker <johnthacker@gmail.com> | 2021-10-15 19:03:10 -0400 |
|---|---|---|
| committer | Wireshark GitLab Utility <gerald+gitlab-utility@wireshark.org> | 2021-10-16 02:26:27 +0000 |
| commit | 9f890e1deae8f858f7203878d8f05a1c20f7f9ed (patch) | |
| tree | a1cc1b1c4ab8e7cbbd9fe4bdbb1f3b8baef2986b | |
| parent | 06890ea379ee833fc15cc08023a153bb89741651 (diff) | |
dfilter: Update semcheck comment to reflect latest commits
The handling of unparsed values was rationalized by commits
c484ad0e5c6cadcda02a7079aa53b76be418c391 and
144dc1e2eefbb3e19b78ccb4a8c2c57bba9c212b. Update this comment
to reflect the new behavior.
| -rw-r--r-- | epan/dfilter/semcheck.c | 15 |
1 files changed, 6 insertions, 9 deletions
diff --git a/epan/dfilter/semcheck.c b/epan/dfilter/semcheck.c index fb2ae8b9fd..be9a5ec145 100644 --- a/epan/dfilter/semcheck.c +++ b/epan/dfilter/semcheck.c @@ -1280,16 +1280,13 @@ check_relation(dfwork_t *dfw, const char *relation_string, * protocol, or similar for a number of other possibilities * ("dc", "ff", "fefd"), and also catches the case where the user * has written a generic string on the RHS for a "contains" or - * "matches" relation. (XXX: There's still a bit of a confusing mess; - * byte arrays take precedent over generic strings when unquoted, so - * "field contains data" matches "\x64 \x61 \x74 \x61" but - * "field contains dc" matches "\xdc" and not "\x64 \x43", but that's - * an underlying issue.) + * "matches" relation with a string field. (The now unparsed value + * will be interpreted in a way that matches the LHS; e.g. + * FT_PROTOCOL and FT_BYTES fields expect byte arrays whereas + * FT_STRING[Z][PAD] fields expect strings.) * - * XXX: Is there a better way to do this in the lex scanner or grammar - * parser step instead? Should the determination of whether something - * is a field occur later than it does currently? This is kind of a - * hack. + * XXX: Is there a better way to do this in the grammar parser, + * which now determines whether something is a field? */ if (stnode_type_id(st_arg2) == STTYPE_FIELD) { |