aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorDr. Lars Völker <lars.voelker@technica-engineering.de>2020-03-19 19:10:41 +0100
committerPascal Quantin <pascal@wireshark.org>2020-03-19 20:32:48 +0000
commitf5c39a33b733cfc8510a6909fbd2a0bb1126237b (patch)
tree1a5d1ffc1836951fe380eff6a0b72b9b5137657d
parentac3ca74bcecdd57932d8fc11360de4131f5086cf (diff)
SOMEIP: SD did not register port for IPv6 correctly (bugfix)
SOME/IP-SD did not register a port learned correctly, so that packets with this port number were not dissected. Bug: 16448 Change-Id: Ic648a50bf08dcab65c49182e08257cf6660261a5 Signed-off-by: Dr. Lars Völker <lars.voelker@technica-engineering.de> Reviewed-on: https://code.wireshark.org/review/36503 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin <pascal@wireshark.org>
-rw-r--r--epan/dissectors/packet-someip-sd.c7
1 files changed, 4 insertions, 3 deletions
diff --git a/epan/dissectors/packet-someip-sd.c b/epan/dissectors/packet-someip-sd.c
index 4e8b278799..c32d0ef26c 100644
--- a/epan/dissectors/packet-someip-sd.c
+++ b/epan/dissectors/packet-someip-sd.c
@@ -1,7 +1,8 @@
/* packet-someip.c
* SOME/IP-SD dissector.
- * By Dr. Lars Voelker <lars-github@larsvoelker.de> / <lars.voelker@bmw.de>
- * Copyright 2012-2019 Dr. Lars Voelker
+ * By Dr. Lars Voelker <lars.voelker@technica-engineering.de> / <lars.voelker@bmw.de>
+ * Copyright 2012-2020 Dr. Lars Voelker
+ * Copyright 2020 Ayoub Kaanich
* Copyright 2019 Ana Pantar
* Copyright 2019 Guenter Ebermann
*
@@ -360,7 +361,7 @@ dissect_someip_sd_pdu_option_ipv6(tvbuff_t *tvb, packet_info *pinfo, proto_tree
}
offset += 1;
- proto_tree_add_item(tree, hf_someip_sd_option_port, tvb, offset, 2, ENC_BIG_ENDIAN);
+ proto_tree_add_item_ret_uint(tree, hf_someip_sd_option_port, tvb, offset, 2, ENC_BIG_ENDIAN, &l4port);
proto_item_append_text(ti_top, " (%s)", l4protoname);