diff options
| author | AndersBroman <anders.broman@ericsson.com> | 2017-05-09 10:46:57 +0200 |
|---|---|---|
| committer | Anders Broman <a.broman58@gmail.com> | 2017-05-09 08:48:05 +0000 |
| commit | fb44c8ced518aa72ce35d6402ceef70da117f343 (patch) | |
| tree | ff1cfa5e064b83ae54c140d9b51b9960029911b5 | |
| parent | fa5f913256bc16d21f9b9727fdf2cec454059c8d (diff) | |
[GSM RLCMAC] Add comments.
Change-Id: I2d98d8f318fdbe160974a69f50c456683669e57e
Reviewed-on: https://code.wireshark.org/review/21562
Reviewed-by: Anders Broman <a.broman58@gmail.com>
| -rw-r--r-- | epan/dissectors/packet-gsm_rlcmac.c | 10 |
1 files changed, 10 insertions, 0 deletions
diff --git a/epan/dissectors/packet-gsm_rlcmac.c b/epan/dissectors/packet-gsm_rlcmac.c index d0b75696dd..972380fc62 100644 --- a/epan/dissectors/packet-gsm_rlcmac.c +++ b/epan/dissectors/packet-gsm_rlcmac.c @@ -9289,6 +9289,12 @@ dissect_ul_pacch_access_burst(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tre "GPRS UL PACCH ACCESS BURST"); rlcmac_tree = proto_item_add_subtree(ti, ett_gsm_rlcmac); + /* Table 11.2.2.1: PACKET CONTROL ACKNOWLEDGEMENT */ + /* < Packet Control Acknowledgement 11 bit message > ::= -- 11-bit access burst format + * + * < MESSAGE_TYPE : bit (9) == 1111 1100 1 > + * | { < MESSAGE_TYPE : bit (6) == 110111 > + */ if ((bit_length > 8) && (tvb_get_bits16(tvb, 0, 9, ENC_BIG_ENDIAN) == 0x1F9)) { csnStreamInit(&ar, 0, bit_length, pinfo); @@ -9299,6 +9305,10 @@ dissect_ul_pacch_access_burst(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tre csnStreamInit(&ar, 0, bit_length, pinfo); csnStreamDissector(rlcmac_tree, &ar, CSNDESCR(UL_Packet_Control_Ack_TN_RRBP_11_t), tvb, &data->u.UL_Packet_Control_Ack_TN_RRBP_11, ett_gsm_rlcmac); } + /* < Packet Control Acknowledgement 8 bit message > ::= -- 8-bit access burst format + * < MESSAGE_TYPE : bit (6) == 0111 11 > + * | { < MESSAGE_TYPE : bit (3) == 000> + */ else if (tvb_get_bits8(tvb, 0, 6) == 0x1F) { csnStreamInit(&ar, 0, bit_length, pinfo); |