diff options
| author | Harald Welte <laforge@osmocom.org> | 2020-09-11 22:14:05 +0200 |
|---|---|---|
| committer | Harald Welte <laforge@osmocom.org> | 2020-09-11 22:41:20 +0200 |
| commit | 105fa402841f6e83b13f2e558e73dee2d4a2a713 (patch) | |
| tree | db0951834015ba88bd972fd3c7cd4c10fbaafca0 | |
| parent | ee292b11a73e00ea3f5d1e2ee25cf9579f6c7532 (diff) | |
Q.933: Fix decoding of PV Status fieldlaforge/q933
This field is actually a bitmask of four bits. It's somewhat odd
to decode it using a value_string. In any case, the values were
plain wrong (shifted to the left by '1').
See Figure A.3 of ITU-T Q.933
A related pcap file can be found at
https://people.osmocom.org/laforge/pcap/gsmtap-fr-q933-pvc_status.pcap
| -rw-r--r-- | epan/dissectors/packet-q933.c | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/epan/dissectors/packet-q933.c b/epan/dissectors/packet-q933.c index b699d00de3..9ba1f231b7 100644 --- a/epan/dissectors/packet-q933.c +++ b/epan/dissectors/packet-q933.c @@ -1118,9 +1118,10 @@ dissect_q933_link_integrity_verf_ie(tvbuff_t *tvb, int offset, int len, */ static const value_string q933_pvc_status_vals[] = { {0x00, "Inactive"}, - {0x02, "Active"}, - {0x08, "New"}, - {0x0a, "New, Active"}, + {0x01, "Active"}, + {0x02, "Deleted"}, + {0x04, "New"}, + {0x05, "New, Active"}, {0, NULL} }; |