aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorHarald Welte <laforge@osmocom.org>2020-09-11 22:05:54 +0200
committerHarald Welte <laforge@osmocom.org>2020-09-11 22:40:33 +0200
commitee292b11a73e00ea3f5d1e2ee25cf9579f6c7532 (patch)
treecc06a41d6968086f52e665d260c9c7739304285d
parent726e0ccb0a1c491693ee73c0f29ff3a7fd73d301 (diff)
Q,933: Fix display of 'active' bit in PVC Status
The mask applied to the final octet of the PVC Status IE must be 0x0E, not 0x0A. The current code masks out the active bit, printing a '.' instead of it. See Figure A.3 of ITU-T Q.933 A related pcap file can be found at https://people.osmocom.org/laforge/pcap/gsmtap-fr-q933-pvc_status.pcapc
-rw-r--r--epan/dissectors/packet-q933.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/epan/dissectors/packet-q933.c b/epan/dissectors/packet-q933.c
index ec934714e2..b699d00de3 100644
--- a/epan/dissectors/packet-q933.c
+++ b/epan/dissectors/packet-q933.c
@@ -2162,7 +2162,7 @@ proto_register_q933(void)
{ &hf_q933_timer, { "Timer", "q933.timer", FT_STRING, BASE_NONE, NULL, 0x0, NULL, HFILL }},
{ &hf_q933_call_state, { "Call state", "q933.call_state", FT_UINT8, BASE_HEX, VALS(q933_call_state_vals), 0x3F, NULL, HFILL }},
{ &hf_q933_dlci, { "DLCI", "q933.dlci", FT_UINT32, BASE_DEC, NULL, 0x0, NULL, HFILL }},
- { &hf_q933_status, { "Status", "q933.status", FT_UINT8, BASE_DEC, VALS(q933_pvc_status_vals), 0x0A, NULL, HFILL }},
+ { &hf_q933_status, { "Status", "q933.status", FT_UINT8, BASE_DEC, VALS(q933_pvc_status_vals), 0x0E, NULL, HFILL }},
{ &hf_q933_interface_identified, { "Interface", "q933.interface_identified", FT_BOOLEAN, 8, TFS(&tfs_explicitly_implicitly_identified), Q933_INTERFACE_IDENTIFIED, NULL, HFILL }},
{ &hf_q933_interface_basic, { "Interface", "q933.interface_basic", FT_BOOLEAN, 8, TFS(&tfs_not_basic_basic), Q933_NOT_BASIC_CHANNEL, NULL, HFILL }},
{ &hf_q933_indicated_channel_required, { "Indicated channel", "q933.indicated_channel_required", FT_BOOLEAN, 8, TFS(&tfs_required_preferred), 0x08, NULL, HFILL }},