Eliminate unused structure members and an unused list.

We don't use the addresses, and don't use the inbound port.

We also don't need a list of tn5250_conv_info_t's - they're allocated
with wmem, so they get freed when we're done with a file, and they're
attached to conversations, so we don't need a list to find them.

Change-Id: Id3b44fb11cf353d7d15a58938883f2460cf642a0
Reviewed-on: https://code.wireshark.org/review/26301
Reviewed-by: Guy Harris <guy@alum.mit.edu>

1 files changed, 0 insertions, 10 deletions

diff --git a/epan/dissectors/packet-tn5250.c b/epan/dissectors/packet-tn5250.c
index f9d9bc13e5..2786b9f720 100644
--- a/epan/dissectors/packet-tn5250.c
+++ b/epan/dissectors/packet-tn5250.c
@@ -28,10 +28,7 @@ void proto_register_tn5250(void);
 
 typedef struct tn5250_conv_info_t {
   struct tn5250_conv_info_t *next;
-  address outbound_addr;
   guint32 outbound_port;
-  address inbound_addr;
-  guint32 inbound_port;
   gint extended;
 } tn5250_conv_info_t;
 
@@ -2886,8 +2883,6 @@ static gint ett_cc = -1;
 
 static expert_field ei_tn5250_command_code = EI_INIT;
 
-static tn5250_conv_info_t *tn5250_info_items;
-
 static guint32 dissect_tn5250_orders_and_data(proto_tree *tn5250_tree, tvbuff_t *tvb, gint offset);
 
 typedef struct hf_items {
@@ -5167,13 +5162,8 @@ add_tn5250_conversation(packet_info *pinfo, int tn5250e)
      * it to the list of information structures.
      */
     tn5250_info = wmem_new(wmem_file_scope(), tn5250_conv_info_t);
-    copy_address_wmem(wmem_file_scope(), &(tn5250_info->outbound_addr),&(pinfo->dst));
     tn5250_info->outbound_port = pinfo->destport;
-    copy_address_wmem(wmem_file_scope(), &(tn5250_info->inbound_addr),&(pinfo->src));
-    tn5250_info->inbound_port = pinfo->srcport;
     conversation_add_proto_data(conversation, proto_tn5250, tn5250_info);
-    tn5250_info->next = tn5250_info_items;
-    tn5250_info_items = tn5250_info;
   }
 
   tn5250_info->extended = tn5250e;