diff options
author | Guy Harris <guy@alum.mit.edu> | 2019-05-25 11:18:55 -0700 |
---|---|---|
committer | Guy Harris <guy@alum.mit.edu> | 2019-05-25 18:19:57 +0000 |
commit | 6ca48b2b6638f34e23b74cc4f268395750553c42 (patch) | |
tree | 45acb189bb610374a3460df39b2a163cd4eef1a4 | |
parent | b942ef0615c405c1f441fa98fe5aa46b4dcfdce0 (diff) |
Ask, in a comment, how to distinguish integer from string tag names.
Change-Id: I6b71ffda03e207c97ca39e37d8da2f440b01b680
Reviewed-on: https://code.wireshark.org/review/33359
Reviewed-by: Guy Harris <guy@alum.mit.edu>
-rw-r--r-- | epan/dissectors/packet-edonkey.c | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/epan/dissectors/packet-edonkey.c b/epan/dissectors/packet-edonkey.c index a21e87f956..ca2ac34e3c 100644 --- a/epan/dissectors/packet-edonkey.c +++ b/epan/dissectors/packet-edonkey.c @@ -671,6 +671,11 @@ static proto_item* edonkey_tree_add_metatag_name(proto_tree *tree, tvbuff_t *tvb gint start, gint length, guint8 special_tagtype) { const gchar *tag_name; + + /* + * XXX - what, in the *protocol*, distinguishes integral from string + * tag names? Name length > 1 means "string"? Something else? + */ tag_name = try_val_to_str(special_tagtype, edonkey_special_tags); if (tag_name == NULL) { return proto_tree_add_item(tree, hf_edonkey_metatag_name, tvb, start, length, ENC_ASCII|ENC_NA); |