diff options
| author | Alexis La Goutte <alexis.lagoutte@gmail.com> | 2022-01-20 11:28:45 +0000 |
|---|---|---|
| committer | A Wireshark GitLab Utility <gerald+gitlab-utility@wireshark.org> | 2022-01-30 09:35:11 +0000 |
| commit | 342ad4a083775ee3ac4cf01127efab2ea95dc589 (patch) | |
| tree | a451d485d277dd414746f69506a4c408e5fbad21 | |
| parent | 226193a18f3409c923dabf021cc5fc7abffda4d0 (diff) | |
ssh: fix warnings found by Clang Analyzer (deadcode.DeadStores)
packet-ssh.c:2502:17: warning: Value stored to 'offset' is never read [deadcode.DeadStores]
packet-ssh.c:2511:17: warning: Value stored to 'offset' is never read [deadcode.DeadStores]
packet-ssh.c:2516:17: warning: Value stored to 'offset' is never read [deadcode.DeadStores]
packet-ssh.c:2532:17: warning: Value stored to 'offset' is never read [deadcode.DeadStores]
packet-ssh.c:2535:17: warning: Value stored to 'offset' is never read [deadcode.DeadStores]
packet-ssh.c:2538:17: warning: Value stored to 'offset' is never read [deadcode.DeadStores]
packet-ssh.c:2561:25: warning: Value stored to 'offset' is never read [deadcode.DeadStores]
packet-ssh.c:2564:25: warning: Value stored to 'offset' is never read [deadcode.DeadStores]
packet-ssh.c:2568:17: warning: Value stored to 'offset' is never read [deadcode.DeadStores]
| -rw-r--r-- | epan/dissectors/packet-ssh.c | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/epan/dissectors/packet-ssh.c b/epan/dissectors/packet-ssh.c index 17f6c5ceb2..73ae755a9a 100644 --- a/epan/dissectors/packet-ssh.c +++ b/epan/dissectors/packet-ssh.c @@ -534,7 +534,7 @@ static gboolean ssh_decrypt_chacha20(gcry_cipher_hd_t hd, guint32 seqnr, static int ssh_dissect_decrypted_packet(tvbuff_t *tvb, packet_info *pinfo, struct ssh_peer_data *peer_data, proto_tree *tree, gchar *plaintext, guint plaintext_len); -static void ssh_dissect_connection_specific(tvbuff_t *packet_tvb, packet_info *pinfo, +static int ssh_dissect_connection_specific(tvbuff_t *packet_tvb, packet_info *pinfo, struct ssh_peer_data *peer_data, int offset, proto_item *msg_type_tree, guint msg_code); @@ -2481,7 +2481,7 @@ ssh_dissect_decrypted_packet(tvbuff_t *tvb, packet_info *pinfo, return offset; } -static void +static int ssh_dissect_connection_specific(tvbuff_t *packet_tvb, packet_info *pinfo, struct ssh_peer_data *peer_data, int offset, proto_item *msg_type_tree, guint msg_code) @@ -2567,6 +2567,7 @@ ssh_dissect_connection_specific(tvbuff_t *packet_tvb, packet_info *pinfo, proto_tree_add_item(msg_type_tree, hf_ssh_connection_recipient_channel, packet_tvb, offset, 4, ENC_BIG_ENDIAN); offset += 4; } + return offset; } static dissector_handle_t |