aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorGuy Harris <gharris@sonic.net>2021-05-23 17:04:59 -0700
committerGuy Harris <gharris@sonic.net>2021-05-23 17:04:59 -0700
commit1bb64b7e0ca46442b3f3a65e4b99893674b3c287 (patch)
treed5fb1ee849baf27466eabcbee44d59c74607a6de
parent618661b22e34a59b21117db723d8ff91e064d4ba (diff)
tacacs: free a buffer if it's not used.
Plugs a leak.
-rw-r--r--epan/dissectors/packet-tacacs.c4
1 files changed, 3 insertions, 1 deletions
diff --git a/epan/dissectors/packet-tacacs.c b/epan/dissectors/packet-tacacs.c
index 223678d3d5..fdd6e98c13 100644
--- a/epan/dissectors/packet-tacacs.c
+++ b/epan/dissectors/packet-tacacs.c
@@ -797,8 +797,10 @@ mkipv4_address( address **addr, const char *str_addr )
ret = str_to_ip(str_addr, addr_data);
if (ret)
set_address(*addr, AT_IPv4, 4, addr_data);
- else
+ else {
+ g_free(addr_data); /* not set, not used */
set_address(*addr, AT_STRINGZ, (int)strlen(ADDR_INVLD)+1, ADDR_INVLD);
+ }
}
static void
parse_tuple( char *key_from_option )