diff options
author | Gerald Combs <gerald@wireshark.org> | 2015-09-03 11:46:20 -0700 |
---|---|---|
committer | Gerald Combs <gerald@wireshark.org> | 2015-09-03 21:48:48 +0000 |
commit | e4d9ce18d8008e29c824d6de89b04eb486532755 (patch) | |
tree | ef20e949a410782d6d319d9b0e692dea38bcd665 | |
parent | 04913778d899939cefbcfa47de50e9c9a1aa0447 (diff) |
Move IAX2 analysis to the ui directory.
Rename ui/gtk/iax2_analysis.h to ui/tap-iax2-analysis.h. Move
iax2_packet_analyse to ui/tap-iax2-analysis.c.
Rename rtp_analysis.h to tap-rtp-analysis.h to match IAX2.
Change-Id: Ice7e9ad0d7bf62d631850089c880ec09a3e101dd
Reviewed-on: https://code.wireshark.org/review/10375
Reviewed-by: Gerald Combs <gerald@wireshark.org>
-rw-r--r-- | ui/CMakeLists.txt | 4 | ||||
-rw-r--r-- | ui/Makefile.common | 4 | ||||
-rw-r--r-- | ui/gtk/Makefile.common | 1 | ||||
-rw-r--r-- | ui/gtk/iax2_analysis.c | 97 | ||||
-rw-r--r-- | ui/gtk/rtp_analysis.c | 2 | ||||
-rw-r--r-- | ui/gtk/voip_calls_dlg.c | 2 | ||||
-rw-r--r-- | ui/qt/rtp_analysis_dialog.h | 2 | ||||
-rw-r--r-- | ui/rtp_stream.h | 2 | ||||
-rw-r--r-- | ui/tap-iax2-analysis.c | 148 | ||||
-rw-r--r-- | ui/tap-iax2-analysis.h (renamed from ui/gtk/iax2_analysis.h) | 108 | ||||
-rw-r--r-- | ui/tap-rtp-analysis.h (renamed from ui/rtp_analysis.h) | 11 | ||||
-rw-r--r-- | ui/tap-rtp-common.c | 13 |
12 files changed, 233 insertions, 161 deletions
diff --git a/ui/CMakeLists.txt b/ui/CMakeLists.txt index f611c7da16..6bf323733a 100644 --- a/ui/CMakeLists.txt +++ b/ui/CMakeLists.txt @@ -49,6 +49,7 @@ set(COMMON_UI_SRC software_update.c ssl_key_export.c tap_export_pdu.c + tap-iax2-analysis.c tap-rtp-common.c tap-sctp-analysis.c tap-sequence-analysis.c @@ -62,8 +63,9 @@ set(COMMON_UI_SRC # Enables visibility in IDEs file(GLOB EXTRA_UI_HEADERS - rtp_analysis.h rtp_stream.h + tap-iax2-analysis.h + tap-rtp-analysis.h ) set(DIRTY_UI_SRC) diff --git a/ui/Makefile.common b/ui/Makefile.common index 3f215d112d..81bd16ffa0 100644 --- a/ui/Makefile.common +++ b/ui/Makefile.common @@ -70,6 +70,7 @@ WIRESHARK_UI_SRC = \ software_update.c \ ssl_key_export.c \ tap_export_pdu.c \ + tap-iax2-analysis.c \ tap-rtp-common.c \ tap-sctp-analysis.c \ tap-sequence-analysis.c \ @@ -106,13 +107,14 @@ noinst_HEADERS = \ proto_hier_stats.h \ recent.h \ recent_utils.h \ - rtp_analysis.h \ rtp_stream.h \ service_response_time.h \ simple_dialog.h \ software_update.h \ ssl_key_export.h \ tap_export_pdu.h \ + tap-iax2-analysis.h \ + tap-rtp-analysis.h \ tap-rtp-common.h \ tap-sctp-analysis.h \ tap-sequence-analysis.h \ diff --git a/ui/gtk/Makefile.common b/ui/gtk/Makefile.common index cce7d8eae8..a46e656caa 100644 --- a/ui/gtk/Makefile.common +++ b/ui/gtk/Makefile.common @@ -228,7 +228,6 @@ noinst_HEADERS = \ gui_utils.h \ help_dlg.h \ hostlist_table.h \ - iax2_analysis.h \ keys.h \ layouts.h \ lbm_stream_dlg.h \ diff --git a/ui/gtk/iax2_analysis.c b/ui/gtk/iax2_analysis.c index f0bc3eaad1..054ffb3e5b 100644 --- a/ui/gtk/iax2_analysis.c +++ b/ui/gtk/iax2_analysis.c @@ -78,8 +78,8 @@ #include "ui/gtk/gui_utils.h" #include "ui/gtk/gui_stat_menu.h" #include "ui/gtk/main.h" -#include "ui/rtp_analysis.h" -#include "ui/gtk/iax2_analysis.h" +#include "ui/tap-rtp-analysis.h" +#include "ui/tap-iax2-analysis.h" #include "ui/rtp_stream.h" #include "ui/gtk/rtp_stream_dlg.h" #include "ui/gtk/old-gtk-compat.h" @@ -499,99 +499,6 @@ iax2_packet(void *user_data_arg, packet_info *pinfo, epan_dissect_t *edt _U_, co return FALSE; } -/****************************************************************************/ -/* This comes from tap-rtp-common.c */ -/****************************************************************************/ - -int iax2_packet_analyse(tap_iax2_stat_t *statinfo, - packet_info *pinfo, - const struct _iax2_info_t *iax2info) -{ - double current_time; - double current_jitter; - double current_diff; - - statinfo->flags = 0; - /* check payload type */ - if (iax2info->ftype == AST_FRAME_VOICE) { - if (iax2info->csub != statinfo->pt) - statinfo->flags |= STAT_FLAG_PT_CHANGE; - statinfo->pt = iax2info->csub; - } - - /* store the current time and calculate the current jitter */ - current_time = nstime_to_sec(&pinfo->rel_ts); - current_diff = fabs (current_time - statinfo->time - (((double)iax2info->timestamp - (double)statinfo->timestamp)/1000)); - current_jitter = statinfo->jitter + ( current_diff - statinfo->jitter)/16; - statinfo->delta = current_time - (statinfo->time); - statinfo->jitter = current_jitter; - statinfo->diff = current_diff; - - /* calculate the BW in Kbps adding the IP+IAX2 header to the RTP -> 20bytes(IP)+ 4bytes(Mini) = 24bytes */ - statinfo->bw_history[statinfo->bw_index].bytes = iax2info->payload_len + 24; - statinfo->bw_history[statinfo->bw_index].time = current_time; - /* check if there are more than 1sec in the history buffer to calculate BW in bps. If so, remove those for the calculation */ - while ((statinfo->bw_history[statinfo->bw_start_index].time+1) < current_time) { - statinfo->total_bytes -= statinfo->bw_history[statinfo->bw_start_index].bytes; - statinfo->bw_start_index++; - if (statinfo->bw_start_index == BUFF_BW) statinfo->bw_start_index = 0; - }; - statinfo->total_bytes += iax2info->payload_len + 24; - statinfo->bandwidth = (double)(statinfo->total_bytes*8)/1000; - statinfo->bw_index++; - if (statinfo->bw_index == BUFF_BW) statinfo->bw_index = 0; - - - /* is this the first packet we got in this direction? */ - if (statinfo->first_packet) { - statinfo->start_seq_nr = 0; - statinfo->start_time = current_time; - statinfo->delta = 0; - statinfo->jitter = 0; - statinfo->diff = 0; - statinfo->flags |= STAT_FLAG_FIRST; - statinfo->first_packet = FALSE; - } - /* is it a regular packet? */ - if (!(statinfo->flags & STAT_FLAG_FIRST) - && !(statinfo->flags & STAT_FLAG_MARKER) - && !(statinfo->flags & STAT_FLAG_PT_CN) - && !(statinfo->flags & STAT_FLAG_WRONG_TIMESTAMP) - && !(statinfo->flags & STAT_FLAG_FOLLOW_PT_CN)) { - /* include it in maximum delta calculation */ - if (statinfo->delta > statinfo->max_delta) { - statinfo->max_delta = statinfo->delta; - statinfo->max_nr = pinfo->fd->num; - } - /* maximum and mean jitter calculation */ - if (statinfo->jitter > statinfo->max_jitter) { - statinfo->max_jitter = statinfo->jitter; - } - statinfo->mean_jitter = (statinfo->mean_jitter*statinfo->total_nr + current_diff) / (statinfo->total_nr+1); - } - /* regular payload change? (CN ignored) */ - if (!(statinfo->flags & STAT_FLAG_FIRST) - && !(statinfo->flags & STAT_FLAG_PT_CN)) { - if ((statinfo->pt != statinfo->reg_pt) - && (statinfo->reg_pt != PT_UNDEFINED)) { - statinfo->flags |= STAT_FLAG_REG_PT_CHANGE; - } - } - - /* set regular payload*/ - if (!(statinfo->flags & STAT_FLAG_PT_CN)) { - statinfo->reg_pt = statinfo->pt; - } - - /* TODO: lost packets / duplicated: we should infer this from timestamp... */ - statinfo->time = current_time; - statinfo->timestamp = iax2info->timestamp; /* millisecs */ - statinfo->stop_seq_nr = 0; - statinfo->total_nr++; - - return 0; -} - #if 0 static const GdkColor COLOR_DEFAULT = {0, 0xffff, 0xffff, 0xffff}; diff --git a/ui/gtk/rtp_analysis.c b/ui/gtk/rtp_analysis.c index e33e25932f..beb62afe6f 100644 --- a/ui/gtk/rtp_analysis.c +++ b/ui/gtk/rtp_analysis.c @@ -78,8 +78,8 @@ #include "ui/gtk/gui_stat_menu.h" #include "ui/gtk/pixmap_save.h" #include "ui/gtk/main.h" -#include "ui/rtp_analysis.h" #include "ui/rtp_stream.h" +#include "ui/tap-rtp-analysis.h" #include "ui/gtk/rtp_stream_dlg.h" #include "ui/gtk/stock_icons.h" diff --git a/ui/gtk/voip_calls_dlg.c b/ui/gtk/voip_calls_dlg.c index 1e45233e7a..0fdcea5af5 100644 --- a/ui/gtk/voip_calls_dlg.c +++ b/ui/gtk/voip_calls_dlg.c @@ -55,7 +55,7 @@ #include "ui/gtk/stock_icons.h" #ifdef HAVE_LIBPORTAUDIO -#include "ui/rtp_analysis.h" +#include "ui/tap-rtp-analysis.h" #include "ui/gtk/rtp_player.h" #endif /* HAVE_LIBPORTAUDIO */ diff --git a/ui/qt/rtp_analysis_dialog.h b/ui/qt/rtp_analysis_dialog.h index eea724113a..cd83a6cd2a 100644 --- a/ui/qt/rtp_analysis_dialog.h +++ b/ui/qt/rtp_analysis_dialog.h @@ -28,8 +28,8 @@ #include "epan/address.h" -#include "ui/rtp_analysis.h" #include "ui/rtp_stream.h" +#include "ui/tap-rtp-analysis.h" #include <QAbstractButton> #include <QMenu> diff --git a/ui/rtp_stream.h b/ui/rtp_stream.h index 2df54e9a03..358ec17890 100644 --- a/ui/rtp_stream.h +++ b/ui/rtp_stream.h @@ -35,7 +35,7 @@ extern "C" { #endif /* __cplusplus */ -#include "rtp_analysis.h" +#include "tap-rtp-analysis.h" #include <glib.h> #include <stdio.h> diff --git a/ui/tap-iax2-analysis.c b/ui/tap-iax2-analysis.c new file mode 100644 index 0000000000..da06e279f1 --- /dev/null +++ b/ui/tap-iax2-analysis.c @@ -0,0 +1,148 @@ +/* tap-iax2-analysis.c + * IAX2 analysis addition for Wireshark + * + * based on rtp_analysis.c + * Copyright 2003, Alcatel Business Systems + * By Lars Ruoff <lars.ruoff@gmx.net> + * + * based on tap_rtp.c + * Copyright 2003, Iskratel, Ltd, Kranj + * By Miha Jemec <m.jemec@iskratel.si> + * + * Wireshark - Network traffic analyzer + * By Gerald Combs <gerald@wireshark.org> + * Copyright 1998 Gerald Combs + * + * This program is free software; you can redistribute it and/or + * modify it under the terms of the GNU General Public License + * as published by the Free Software Foundation; either version 2 + * of the License, or (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * You should have received a copy of the GNU General Public License + * along with this program; if not, write to the Free Software + * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. + */ + +#include "config.h" + +#include <math.h> + +#include <glib.h> + +#include <epan/circuit.h> + +#include <epan/dissectors/packet-iax2.h> + +#include "tap-iax2-analysis.h" + +/****************************************************************************/ +/* This comes from tap-rtp-common.c */ +/****************************************************************************/ + + void +iax2_packet_analyse(tap_iax2_stat_t *statinfo, + packet_info *pinfo, + const struct _iax2_info_t *iax2info) +{ + double current_time; + double current_jitter; + double current_diff; + + statinfo->flags = 0; + /* check payload type */ + if (iax2info->ftype == AST_FRAME_VOICE) { + if (iax2info->csub != statinfo->pt) + statinfo->flags |= STAT_FLAG_PT_CHANGE; + statinfo->pt = iax2info->csub; + } + + /* store the current time and calculate the current jitter */ + current_time = nstime_to_sec(&pinfo->rel_ts); + current_diff = fabs (current_time - statinfo->time - (((double)iax2info->timestamp - (double)statinfo->timestamp)/1000)); + current_jitter = statinfo->jitter + ( current_diff - statinfo->jitter)/16; + statinfo->delta = current_time - (statinfo->time); + statinfo->jitter = current_jitter; + statinfo->diff = current_diff; + + /* calculate the BW in Kbps adding the IP+IAX2 header to the RTP -> 20bytes(IP)+ 4bytes(Mini) = 24bytes */ + statinfo->bw_history[statinfo->bw_index].bytes = iax2info->payload_len + 24; + statinfo->bw_history[statinfo->bw_index].time = current_time; + /* check if there are more than 1sec in the history buffer to calculate BW in bps. If so, remove those for the calculation */ + while ((statinfo->bw_history[statinfo->bw_start_index].time+1) < current_time) { + statinfo->total_bytes -= statinfo->bw_history[statinfo->bw_start_index].bytes; + statinfo->bw_start_index++; + if (statinfo->bw_start_index == BUFF_BW) statinfo->bw_start_index = 0; + }; + statinfo->total_bytes += iax2info->payload_len + 24; + statinfo->bandwidth = (double)(statinfo->total_bytes*8)/1000; + statinfo->bw_index++; + if (statinfo->bw_index == BUFF_BW) statinfo->bw_index = 0; + + + /* is this the first packet we got in this direction? */ + if (statinfo->first_packet) { + statinfo->start_seq_nr = 0; + statinfo->start_time = current_time; + statinfo->delta = 0; + statinfo->jitter = 0; + statinfo->diff = 0; + statinfo->flags |= STAT_FLAG_FIRST; + statinfo->first_packet = FALSE; + } + /* is it a regular packet? */ + if (!(statinfo->flags & STAT_FLAG_FIRST) + && !(statinfo->flags & STAT_FLAG_MARKER) + && !(statinfo->flags & STAT_FLAG_PT_CN) + && !(statinfo->flags & STAT_FLAG_WRONG_TIMESTAMP) + && !(statinfo->flags & STAT_FLAG_FOLLOW_PT_CN)) { + /* include it in maximum delta calculation */ + if (statinfo->delta > statinfo->max_delta) { + statinfo->max_delta = statinfo->delta; + statinfo->max_nr = pinfo->fd->num; + } + /* maximum and mean jitter calculation */ + if (statinfo->jitter > statinfo->max_jitter) { + statinfo->max_jitter = statinfo->jitter; + } + statinfo->mean_jitter = (statinfo->mean_jitter*statinfo->total_nr + current_diff) / (statinfo->total_nr+1); + } + /* regular payload change? (CN ignored) */ + if (!(statinfo->flags & STAT_FLAG_FIRST) + && !(statinfo->flags & STAT_FLAG_PT_CN)) { + if ((statinfo->pt != statinfo->reg_pt) + && (statinfo->reg_pt != PT_UNDEFINED)) { + statinfo->flags |= STAT_FLAG_REG_PT_CHANGE; + } + } + + /* set regular payload*/ + if (!(statinfo->flags & STAT_FLAG_PT_CN)) { + statinfo->reg_pt = statinfo->pt; + } + + /* TODO: lost packets / duplicated: we should infer this from timestamp... */ + statinfo->time = current_time; + statinfo->timestamp = iax2info->timestamp; /* millisecs */ + statinfo->stop_seq_nr = 0; + statinfo->total_nr++; + + return; +} + +/* + * Editor modelines - http://www.wireshark.org/tools/modelines.html + * + * Local variables: + * c-basic-offset: 4 + * tab-width: 8 + * indent-tabs-mode: nil + * End: + * + * vi: set shiftwidth=4 tabstop=8 expandtab: + * :indentSize=4:tabSize=8:noTabs=true: + */ diff --git a/ui/gtk/iax2_analysis.h b/ui/tap-iax2-analysis.h index c7bc10ce70..43d196afac 100644 --- a/ui/gtk/iax2_analysis.h +++ b/ui/tap-iax2-analysis.h @@ -1,4 +1,4 @@ -/* iax2_analysis.h +/* tap-iax2-analysis.h * IAX2 analysis addition for Wireshark * * based on rtp_analysis.c @@ -28,10 +28,9 @@ * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. */ -#ifndef __IAX2_ANALYSIS_H__ -#define __IAX2_ANALYSIS_H__ +#ifndef __TAP_IAX2_ANALYSIS_H__ +#define __TAP_IAX2_ANALYSIS_H__ -#include <glib.h> #include <epan/address.h> #include <epan/packet_info.h> @@ -41,56 +40,56 @@ */ void iax2_analysis( - address *ip_src_fwd, - guint16 port_src_fwd, - address *ip_dst_fwd, - guint16 port_dst_fwd, - address *ip_src_rev, - guint16 port_src_rev, - address *ip_dst_rev, - guint16 port_dst_rev - ); + address *ip_src_fwd, + guint16 port_src_fwd, + address *ip_dst_fwd, + guint16 port_dst_fwd, + address *ip_src_rev, + guint16 port_src_rev, + address *ip_dst_rev, + guint16 port_dst_rev + ); /****************************************************************************/ /* structure that holds the information about the forward and reversed direction */ typedef struct _iax2_bw_history_item { - double time; - guint32 bytes; + double time; + guint32 bytes; } iax2_bw_history_item; #define BUFF_BW 300 typedef struct _tap_iax2_stat_t { - gboolean first_packet; /* do not use in code that is called after rtp_packet_analyse */ - /* use (flags & STAT_FLAG_FIRST) instead */ - /* all of the following fields will be initialized after - rtp_packet_analyse has been called */ - guint32 flags; /* see STAT_FLAG-defines below */ - guint16 seq_num; - guint32 timestamp; - guint32 delta_timestamp; - double bandwidth; - iax2_bw_history_item bw_history[BUFF_BW]; - guint16 bw_start_index; - guint16 bw_index; - guint32 total_bytes; - double delta; - double jitter; - double diff; - double time; - double start_time; - double max_delta; - double max_jitter; - double mean_jitter; - guint32 max_nr; - guint16 start_seq_nr; - guint16 stop_seq_nr; - guint32 total_nr; - guint32 sequence; - gboolean under; - gint cycles; - guint16 pt; - int reg_pt; + gboolean first_packet; /* do not use in code that is called after rtp_packet_analyse */ + /* use (flags & STAT_FLAG_FIRST) instead */ + /* all of the following fields will be initialized after + rtp_packet_analyse has been called */ + guint32 flags; /* see STAT_FLAG-defines below */ + guint16 seq_num; + guint32 timestamp; + guint32 delta_timestamp; + double bandwidth; + iax2_bw_history_item bw_history[BUFF_BW]; + guint16 bw_start_index; + guint16 bw_index; + guint32 total_bytes; + double delta; + double jitter; + double diff; + double time; + double start_time; + double max_delta; + double max_jitter; + double mean_jitter; + guint32 max_nr; + guint16 start_seq_nr; + guint16 stop_seq_nr; + guint32 total_nr; + guint32 sequence; + gboolean under; + gint cycles; + guint16 pt; + int reg_pt; } tap_iax2_stat_t; #define PT_UNDEFINED -1 @@ -108,10 +107,23 @@ typedef struct _tap_iax2_stat_t { /* forward */ struct _rtp_info; -/* function for analysing an RTP packet. Called from rtp_analysis and rtp_streams */ -extern int iax2_packet_analyse(tap_iax2_stat_t *statinfo, +/* function for analysing an IAX2 packet. Called from iax2_analysis. */ +extern void iax2_packet_analyse(tap_iax2_stat_t *statinfo, packet_info *pinfo, const struct _iax2_info_t *iax2info); -#endif /* __IAX2_ANALYSIS_H__ */ +#endif /* __TAP_IAX2_ANALYSIS_H__ */ + +/* + * Editor modelines - http://www.wireshark.org/tools/modelines.html + * + * Local variables: + * c-basic-offset: 4 + * tab-width: 8 + * indent-tabs-mode: nil + * End: + * + * vi: set shiftwidth=4 tabstop=8 expandtab: + * :indentSize=4:tabSize=8:noTabs=true: + */ diff --git a/ui/rtp_analysis.h b/ui/tap-rtp-analysis.h index 65dae42699..569d5dfd31 100644 --- a/ui/rtp_analysis.h +++ b/ui/tap-rtp-analysis.h @@ -1,4 +1,4 @@ -/* rtp_analysis.h +/* tap-rtp-analysis.h * RTP analysis addition for Wireshark * * Copyright 2003, Alcatel Business Systems @@ -27,10 +27,9 @@ * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. */ -#ifndef __RTP_ANALYSIS_H__ -#define __RTP_ANALYSIS_H__ +#ifndef __TAP_RTP_ANALYSIS_H__ +#define __TAP_RTP_ANALYSIS_H__ -#include <glib.h> #include <epan/address.h> #include <epan/packet_info.h> @@ -127,7 +126,7 @@ typedef struct _tap_rtp_stat_t { struct _rtp_info; /* function for analysing an RTP packet. Called from rtp_analysis and rtp_streams */ -extern int rtp_packet_analyse(tap_rtp_stat_t *statinfo, +extern void rtp_packet_analyse(tap_rtp_stat_t *statinfo, packet_info *pinfo, const struct _rtp_info *rtpinfo); @@ -135,7 +134,7 @@ extern int rtp_packet_analyse(tap_rtp_stat_t *statinfo, } #endif /* __cplusplus */ -#endif /* __RTP_ANALYSIS_H__ */ +#endif /* __TAP_RTP_ANALYSIS_H__ */ /* * Editor modelines - http://www.wireshark.org/tools/modelines.html diff --git a/ui/tap-rtp-common.c b/ui/tap-rtp-common.c index b164c39ed3..f8d1e22280 100644 --- a/ui/tap-rtp-common.c +++ b/ui/tap-rtp-common.c @@ -29,6 +29,8 @@ #include "config.h" +#include <glib.h> + #include <math.h> #include "globals.h" @@ -405,7 +407,8 @@ get_dyn_pt_clock_rate(const gchar *payload_type_str) } /****************************************************************************/ -int rtp_packet_analyse(tap_rtp_stat_t *statinfo, +void +rtp_packet_analyse(tap_rtp_stat_t *statinfo, packet_info *pinfo, const struct _rtp_info *rtpinfo) { @@ -453,7 +456,7 @@ int rtp_packet_analyse(tap_rtp_stat_t *statinfo, statinfo->flags |= STAT_FLAG_MARKER; } statinfo->first_packet = FALSE; - return 0; + return; } /* Reset flags */ @@ -464,7 +467,7 @@ int rtp_packet_analyse(tap_rtp_stat_t *statinfo, if(!ADDRESSES_EQUAL(&(statinfo->first_packet_mac_addr), &(pinfo->dl_src))){ statinfo->flags |= STAT_FLAG_DUP_PKT; statinfo->delta = current_time-(statinfo->time); - return 0; + return; } } @@ -543,7 +546,7 @@ int rtp_packet_analyse(tap_rtp_stat_t *statinfo, statinfo->pt = rtpinfo->info_payload_type; /* - * Return 0 for unknown payload types + * Return for unknown payload types * Ignore jitter calculation for clockrate = 0 */ if (statinfo->pt < 96 ){ @@ -689,7 +692,7 @@ int rtp_packet_analyse(tap_rtp_stat_t *statinfo, statinfo->stop_seq_nr = rtpinfo->info_seq_num; statinfo->total_nr++; - return 0; + return; } /* |