aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorAnders Broman <anders.broman@ericsson.com>2012-01-24 19:23:05 +0000
committerAnders Broman <anders.broman@ericsson.com>2012-01-24 19:23:05 +0000
commite9ab825ba51f7b0dd5f95b7bc811693aa12c328c (patch)
tree9e620e712e43268f963898c984398a767b36c80b
parent5e00d09f64eac16aef541f4ad30761f28e035eb4 (diff)
max_ul_ext isn't printed/decoded to the packet details log in GTP protocol packet.(Wrong length check)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6761 svn path=/trunk/; revision=40702
-rw-r--r--epan/dissectors/packet-gtp.c7
1 files changed, 4 insertions, 3 deletions
diff --git a/epan/dissectors/packet-gtp.c b/epan/dissectors/packet-gtp.c
index 1e0caa139d..04d9db9561 100644
--- a/epan/dissectors/packet-gtp.c
+++ b/epan/dissectors/packet-gtp.c
@@ -4230,13 +4230,14 @@ static int decode_qos_umts(tvbuff_t * tvb, int offset, proto_tree * tree, const
max_dl_ext = wrapped_tvb_get_guint8(tvb, offset + (13 - 1) * utf8_type + 1, utf8_type);
guar_dl_ext = wrapped_tvb_get_guint8(tvb, offset + (14 - 1) * utf8_type + 1, utf8_type);
}
- if (length > 17) {
+ if (length > 16) {
max_ul_ext = wrapped_tvb_get_guint8(tvb, offset + (15 - 1) * utf8_type + 1, utf8_type);
guar_ul_ext = wrapped_tvb_get_guint8(tvb, offset + (16 - 1) * utf8_type + 1, utf8_type);
}
- /* See above comments for the changes
- * */
+ /*
+ * See above comments for the changes
+ */
proto_tree_add_uint(ext_tree_qos, hf_gtp_qos_traf_class, tvb, offset + (4 - 1) * utf8_type + 1, utf8_type, traf_class);
proto_tree_add_uint(ext_tree_qos, hf_gtp_qos_del_order, tvb, offset + (4 - 1) * utf8_type + 1, utf8_type, del_order);
proto_tree_add_uint(ext_tree_qos, hf_gtp_qos_del_err_sdu, tvb, offset + (4 - 1) * utf8_type + 1, utf8_type, del_err_sdu);