aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorAnders Broman <anders.broman@ericsson.com>2009-07-29 20:58:47 +0000
committerAnders Broman <anders.broman@ericsson.com>2009-07-29 20:58:47 +0000
commit26d1dfcf4caa702a38737a0768375cb0b1e89ace (patch)
tree764a389b80d8f01ad8fe4d63c0871d81b31a71c3
parentad74edb13954ddf3c52edd36b416e4f86646108c (diff)
Add pinfo to new_packet_list_append() this should give us the abillity
to store (most) of the underlying data rather than the strings in the store and render it when we need it, thuss saving storage space and loading time. Idealy we should not store the complete fdata or pinfo structures but rather just the data relevant to the currently selected/used columns. I'm not entierly sure how to accomplish that however. Dynamically allocated array to hold pointers to the actual data? svn path=/trunk/; revision=29237
-rw-r--r--file.c2
-rw-r--r--gtk/new_packet_list.c3
-rw-r--r--ui_util.h2
3 files changed, 4 insertions, 3 deletions
diff --git a/file.c b/file.c
index 24efcaaae0..18225cb541 100644
--- a/file.c
+++ b/file.c
@@ -1132,7 +1132,7 @@ add_packet_to_packet_list(frame_data *fdata, capture_file *cf,
* in the following function when not using the new packet list. */
fdata->color_filter = color_filters_colorize_packet(0, edt);
- row = new_packet_list_append(&cf->cinfo, fdata);
+ row = new_packet_list_append(&cf->cinfo, fdata, &edt->pi);
#else
row = packet_list_append(cf->cinfo.col_data, fdata);
diff --git a/gtk/new_packet_list.c b/gtk/new_packet_list.c
index bdad8d0495..2ebcb648b3 100644
--- a/gtk/new_packet_list.c
+++ b/gtk/new_packet_list.c
@@ -41,6 +41,7 @@
#include "packet_list_store.h"
#include "epan/column_info.h"
#include "epan/prefs.h"
+#include <epan/packet.h>
#include "../ui_util.h"
#include "epan/emem.h"
#include "globals.h"
@@ -98,7 +99,7 @@ new_packet_list_create(void)
}
guint
-new_packet_list_append(column_info *cinfo, frame_data *fdata)
+new_packet_list_append(column_info *cinfo, frame_data *fdata, packet_info *pinfo _U_)
{
gint i;
row_data_t row_data;
diff --git a/ui_util.h b/ui_util.h
index 92e5bb285a..6816f1e887 100644
--- a/ui_util.h
+++ b/ui_util.h
@@ -64,7 +64,7 @@ void new_packet_list_freeze(void);
void new_packet_list_thaw(void);
void new_packet_list_next(void);
void new_packet_list_prev(void);
-guint new_packet_list_append(column_info *cinfo, frame_data *fdata);
+guint new_packet_list_append(column_info *cinfo, frame_data *fdata, packet_info *pinfo);
frame_data * new_packet_list_get_row_data(gint row);
void new_packet_list_set_selected_row(gint row);
void new_packet_list_enable_color(gboolean enable);